Conversation
|
We already have testing code for checking pixels sizes (since we get pixel sizes set "for free" when we import OME.xml). See https://github.com/ome/omero-cli-zarr/blob/10df9400245a8ffdf6e6557bf0690841972e1998/test/integration/clitest/test_import.py#L60C10-L60C23 where we get 3 images imported in the Fileset and this specifies the expected pixel_size_x for each image. So if you could add a similar list to the other samples e.g. |
|
Another thought: could we also set the I'm not sure we have any samples with correct Time values in the |
|
@will-moore Timeincrement can go in a follow-up PR. |
|
OK let's chat... What was the test failing with? |
|
@will-moore Test adjusted to check the value |
|
Conflicting PR. Removed from build OMERO-plugins-push#44. See the console output for more details.
|
will-moore
left a comment
There was a problem hiding this comment.
Tested the various samples from test_import.py, importing them via CLI to merge-ci.
All had pixel sizes set as expected 👍
|
Thanks @will-moore. Merging so we can fix the conflicts |
Read Ome-zarr pixel size and set Omero pixel size
This PR integrates changes suggested in BioNGFF/omero-import-utils#28 and fixes a few issues noticed while running the tests
cc @folterj