Closed
Conversation
Member
|
Member
Author
|
thanks @jburel ! I have just verified that the build is passing on my branch with simply your branch on an already opened PR of yours #461 - see https://github.com/pwalczysko/omero-insight/actions/runs/14133456610/job/39599380043 - hence this PR is not needed. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just maybe to highlight that the build is failing here.
I believe the bump of the actions versions is helping (implemented here).
But I am failing on finding an artifact.
Imho, the artifact is here (see https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow)
https://repo.maven.apache.org/maven2/com/gradleup/shadow/com.gradleup.shadow.gradle.plugin/8.3.0/
But I do not know how to cite it correctly in the gradle.yml, so it still fails....
Anyhow, at least a heads-up
cc @sbesson @jburel @dominikl