Skip to content

Split view user label #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knabar merged 8 commits into from
Feb 6, 2026
Merged

Split view user label #639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3280829
Adding support for user input labels
Rdornier Nov 13, 2025
71ea113
removing console.logs
Rdornier Nov 13, 2025
5145014
adding support to add a different label for each image
Rdornier Nov 19, 2025
f40bb0e
update separators
Rdornier Nov 20, 2025
1f4fc42
fix UI layout
Rdornier Nov 27, 2025
1087aff
check if new script is available
Rdornier Dec 10, 2025
6fd58f1
remove debug line
Rdornier Jan 20, 2026
a994a60
Merge branch 'ome:master' into split-view-user-label
Rdornier Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions omeroweb/webclient/templates/webclient/scripts/split_view_figure.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ <h2 style="color: red">{{ warning }}</h2>
<option value="Image Name" selected="True" >Image Name</option>
<option value="Datasets" >Datasets</option>
<option value="Tags" >Tags</option>
<option value="Custom" >Custom</option>
{% if custom_labels_supported %}
<option value="Custom" >Custom</option>
{% endif %}
</select>
</td>
{% for c in channels %}
Expand All @@ -226,22 +228,24 @@ <h2 style="color: red">{{ warning }}</h2>
</td>
</tr>
</table>

<hr />

<div title="Custom label" class="customLabelInput" align="center" style="display:none;position:relative;left:float;">
Custom label:
<input type="text" name="Custom_Label" value="" />
<select name="Image_Custom_Label_List" style="margin-right:20px;display:none;">
<option value="All" selected="True">All Images</option>
{% for imgData in imgDict %}
<option value="{{ imgData.id }}">{{imgData.name}}</option>
{% endfor %}
</select>
</div>
<div title="All custom labels" class="allLabels" style="display:none">
<input type="text" name="All_labels" value="" />
</div>
{% if custom_labels_supported %}
<hr />

<div title="Custom label" class="customLabelInput" align="center" style="display:none;position:relative;left:float;">
Custom label:
<input type="text" name="Custom_Label" value="" />
<select name="Image_Custom_Label_List" style="margin-right:20px;display:none;">
<option value="All" selected="True">All Images</option>
{% for imgData in imgDict %}
<option value="{{ imgData.id }}">{{imgData.name}}</option>
{% endfor %}
</select>
</div>
<div title="All custom labels" class="allLabels" style="display:none">
<input type="text" name="All_labels" value="" />
</div>
{% endif %}
custom_labels_supported {{ custom_labels_supported }}
Copy link
Member

@will-moore will-moore Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that line was just for debugging in my example - can be removed

{% endblock %}

<!---------------------------- FIGURE PREVIEW ---------------------->
Expand Down
5 changes: 5 additions & 0 deletions omeroweb/webclient/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4410,6 +4410,11 @@ def loadImageTags(imageIds):
if scriptId < 0:
raise AttributeError("No script found for path '%s'" % scriptPath)

if scriptName == "SplitView":
# Check we have script that supports custom labels
params = scriptService.getParams(scriptId)
context["custom_labels_supported"] = "All_labels" in params.inputs

context["template"] = template
context["scriptId"] = scriptId
return context
Expand Down
Loading