Conversation
Update to PHP 8.4 to use property hooks Adds a custom rector rule to change phpstan hints for non-empty-strings to use property hook to validate when setting
…t to use property hook to validate when setting
Apply more set property hooks to value objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
Please include the issue number that this PR addresses. This helps track the completion of the original task.
Fixes #49
Summary of Changes
Updates Valinor and adds Rector rules to enforce value object inputs with property hooks
Testing
PHPStan is all green
Breaking Changes / Migration Notes
Requires upgrading our PHP container to PHP 8.4 to support property hooks.