Clean up language strings, add openomf-translations submodule#737
Clean up language strings, add openomf-translations submodule#737Nopey wants to merge 23 commits intoomf2097:masterfrom
Conversation
7dfff8c to
7fd5bbb
Compare
1909b28 to
59a33b4
Compare
|
This seems messy and difficult. Would it be better to just create our own language files, add only text that is used and include them to the project? Then we could drop the original language files completely. |
|
Should I remove the Dansk Maskinoversottelse? its derivative of ENGLISH.DAT. EDIT: removed. |
4624a25 to
99b68e8
Compare
|
the |
mrannanj
left a comment
There was a problem hiding this comment.
Still undecided about submodules, but initially okay.
Also ensures they are stored sequentially on the heap for better cache-locality.
this PR:
LangPilotdatain a single contigous allocation, and discarding theirdescription.Rationale for using cmake codegen instead of a straight C enum:OMF ENGLISH.DAT consumes 65,397 bytes of memory after discarding the descriptions
A cut down OpenOMF ENGLISH.LNG consumes 35,257 bytes of memory and only contains 458 strings.