Skip to content

Add incremental BK loading#760

Closed
Vagabond wants to merge 8 commits intomasterfrom
adt/incremental-bk-loading
Closed

Add incremental BK loading#760
Vagabond wants to merge 8 commits intomasterfrom
adt/incremental-bk-loading

Conversation

@Vagabond
Copy link
Member

@Vagabond Vagabond commented Nov 7, 2024

On slow hardware, the blocking bk loading can cause the audio to stutter because it blocks the engine loop. This PR makes loading BK files incremental, so the game loop can keep ticking and loading the BK file incrementally during scene transitions.

@Vagabond Vagabond marked this pull request as ready for review November 7, 2024 21:02
@Vagabond
Copy link
Member Author

Vagabond commented Nov 7, 2024

One issue is, on scene transition without a "crossfade" it flickers a bit

Copy link
Member

@Nopey Nopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMF logo to main menu crossfade repeats four times
Other cross fades seem unaffected

EDIT: OpenOMF.bk to intro.bk transition can also repeat four times

2024-11-07.13-07-03.mp4

@Vagabond
Copy link
Member Author

OMF logo to main menu crossfade repeats four times Other cross fades seem unaffected

EDIT: OpenOMF.bk to intro.bk transition can also repeat four times
2024-11-07.13-07-03.mp4

This should be resolved now.

@katajakasa
Copy link
Member

Deprecated in favor of #1015

@katajakasa katajakasa closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants