Conversation
|
It's so cool, thanks. I have some general suggestions, since all people are not Muslims, please change the naming of files and also options in the settings to something like "Islamic prayer timing" or even more accurate "Shia Prayer Timing". And exactly because of the same reason, I would suggest disabling it by default. Because in the future we cannot enable all kind of prayer times at the same time. |
|
Hi,
|
omid
left a comment
omid
left a comment
There was a problem hiding this comment.
Sure, I agree we can improve most of the issued I've mentioned later.
By the way, I put 2-3 comments. It would be awesome if you could take care of them.
| MainLoop.source_remove(this._prayerTimeout); | ||
| this._prayerTimeout = null; | ||
| } | ||
| this._prayerTimeout = MainLoop.timeout_add(60000 - (new Date().getSeconds() * 1000), Lang.bind(this,this._prayerTimeLoop)); |
There was a problem hiding this comment.
You should remove this in the "disable" function.
And I would suggest adding it to the "enable" function.
Another suggestion is to ignore adding timeout when the feature is disabled.
| })); | ||
| item = new Gtk.CheckButton({label: _('Show Pray Time')}); | ||
| this.vbox2.add(item); | ||
| Schema.bind('praytime-visible', item, 'active', Gio.SettingsBindFlags.DEFAULT); |
There was a problem hiding this comment.
Please disable this and Azaan options, by default.
| <description>Display official international events.</description> | ||
| </key> | ||
| <key name="praytime-visible" type="b"> | ||
| <default>true</default> |
There was a problem hiding this comment.
Same here.
Please disable this and Azaan options, by default.
add Prayer song
2 participants
Prayer time based on location and TimeZone
Automatic play
Azaanaudio.