Feature/mit 3148 omise rebranding #494
Conversation
tanksale-asmita
requested review from
AnasNaouchi,
FhanOmise,
Narum11,
hpariwat,
jutinapas,
nattanonch,
new4762 and
rosle
Controller/Callback/Offsite.php
Outdated
| $payment->addTransaction(Transaction::TYPE_PAYMENT, $invoice), | ||
| __( | ||
| "Amount of %1 has been paid via Opn Payments $paymentMethodLabel payment", | ||
| "Amount of %1 has been paid via Omise Payments $paymentMethodLabel payment", |
There was a problem hiding this comment.
Not sure if its just Omise or Omise Payments. I think its the former.
There was a problem hiding this comment.
The Jira ticket mentions as Omise Payments and previous message as well mentioned Opn Payments that is why I went with Omise Payments.
There was a problem hiding this comment.
In WooCommerce Plugin, we're going with Omise Payments as the plugin name. But we keep just Omise in plugin's messages.
I think few places should be updated here, the message that refers to our backend, I think we should keep it Omise, for example:
Omise Payments Dashboard->Omise DashboardThe keys for Omise Payments are invalid/expired->The keys for Omise are invalid/expiredThis Omise Payments account does not support->This Omise account does not support
What do you think?
There was a problem hiding this comment.
@rosle @AnasNaouchi I have made these changes and committed the code.
There was a problem hiding this comment.
@rosle @AnasNaouchi I have made these changes and committed the code.
view/frontend/templates/checkout/onepage/success/paynow_additional_info.phtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Rossukhon Leagmongkol <[email protected]>
…onal_info.phtml Co-authored-by: Rossukhon Leagmongkol <[email protected]>
Co-authored-by: Rossukhon Leagmongkol <[email protected]>
Co-authored-by: Rossukhon Leagmongkol <[email protected]>
|
| <field id="live_secret_key" translate="label" type="password" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="1"> | ||
| <label>Secret key for live</label> | ||
| <comment>The "Live" mode secret key can be found in Opn Payments Dashboard.</comment> | ||
| <comment>The "Live" mode secret key can be found in Omise Dashboard.</comment> |
There was a problem hiding this comment.
suggestion: Not sure if this is intentional but there seems to be 2 whitespaces instead of one.
tanksale-asmita
dismissed stale reviews from FhanOmise and AnasNaouchi
The base branch was changed.
7 participants
Description
Below changes were added to facilitate rebranding from Opn Payment Gateway to Omise Payments.
Related links:
https://opn-ooo.atlassian.net/browse/MIT-3148
Rollback procedure
default rollback procedure