feat: call API delete publish endpoint in termination process #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joerg Zeidler <[email protected]>
Signed-off-by: Joerg Zeidler <[email protected]>
JanZachmann
requested changes
Apr 28, 2025
src/main.rs
Outdated
Comment on lines
201
to
206
| let ods_socket_path_for_api = ods_socket_path.clone(); | ||
| let api_config = Api { | ||
| ods_socket_path, | ||
| ods_socket_path: ods_socket_path_for_api, | ||
| update_os_path: update_os_path!(), | ||
| centrifugo_client_token_hmac_secret_key, | ||
| index_html, |
Contributor
There was a problem hiding this comment.
- move line 189 to 200
let api_config = Api {
ods_socket_path: ods_socket_path.clone(),
update_os_path: update_os_path!(),
centrifugo_client_token_hmac_secret_key,
index_html,
Contributor
Author
There was a problem hiding this comment.
now it should be OK
JanZachmann
requested changes
Apr 28, 2025
src/socket_client.rs
Outdated
| post(request, socket_path).await | ||
| } | ||
|
|
||
| async fn post(request: Request<String>, socket_path: &str) -> Result<HttpResponse> { |
Contributor
There was a problem hiding this comment.
rename to send_request
Signed-off-by: Joerg Zeidler <[email protected]>
Signed-off-by: Joerg Zeidler <[email protected]>
JanZachmann
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.