fix(twin): survive transient iothub disconnects and fix desired property path#43
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
JanZachmann
commented
Mar 11, 2026
JanZachmann
commented
- Replace anyhow::ensure! with exhaustive UnauthenticatedReason match so transient errors (NoNetwork, ExpiredSasToken, etc.) are logged and survived instead of crashing the module.
- Fix desired property path: Complete updates nest location under desired["desired"]["location"]; Partial updates expose it at the top level.
- Adopt lazy client init pattern with tokio::pin! retry loop matching the omnect-device-service reference implementation.
- Add TwinState enum (Uninitialized/Initialized/Authenticated) replacing the authenticated_once bool.
- Add reset_client_with_delay() for BadCredential/CommunicationError recovery.
- Add biased select! and client-presence guards on reported/outgoing branches.
…rty path - Replace anyhow::ensure! with exhaustive UnauthenticatedReason match so transient errors (NoNetwork, ExpiredSasToken, etc.) are logged and survived instead of crashing the module. - Fix desired property path: Complete updates nest location under desired["desired"]["location"]; Partial updates expose it at the top level. - Adopt lazy client init pattern with tokio::pin! retry loop matching the omnect-device-service reference implementation. - Add TwinState enum (Uninitialized/Initialized/Authenticated) replacing the authenticated_once bool. - Add reset_client_with_delay() for BadCredential/CommunicationError recovery. - Add biased select! and client-presence guards on reported/outgoing branches. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.