Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Nov 10, 2025

  • Upgrade dependencies

@pboling pboling self-assigned this Nov 10, 2025
Copilot AI review requested due to automatic review settings November 10, 2025 21:28
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
omniauth-ldap 98% 80%
Summary 98% (286 / 293) 80% (102 / 128)

Minimum allowed line rate is 97%

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (6e44d5a) to head (f67e672).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   96.82%   96.78%   -0.05%     
==========================================
  Files           4        4              
  Lines         315      311       -4     
  Branches      117      117              
==========================================
- Hits          305      301       -4     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the codebase documentation by adding comprehensive YARD documentation across the main library files and updates development dependencies. The changes primarily focus on improving code documentation coverage while also modernizing the development toolchain.

  • Added extensive YARD documentation to lib/omniauth/strategies/ldap.rb, lib/omniauth-ldap/adaptor.rb, lib/omniauth-ldap/version.rb, and lib/omniauth-ldap.rb
  • Updated development dependencies including kettle-dev (v1.1.45 → v1.1.54), removed vcr and webmock dependencies
  • Enhanced documentation tooling with yard-fence, yard-yaml, and yaml-converter

Reviewed Changes

Copilot reviewed 58 out of 63 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/omniauth/strategies/ldap.rb Added comprehensive YARD documentation for the LDAP strategy class, methods, and constants
lib/omniauth-ldap/adaptor.rb Added detailed YARD documentation for the Adaptor class, configuration constants, and methods
lib/omniauth-ldap/version.rb Added YARD documentation for the version module and constants
lib/omniauth-ldap.rb Added module-level YARD documentation
omniauth-ldap.gemspec Commented out vcr and webmock development dependencies
gemfiles/modular/documentation.gemfile Added new documentation dependencies and marked gems with require: false
gemfiles/modular/x_std_libs/*/libs.gemfile Removed logger dependency from multiple Ruby version-specific gemfiles
Gemfile.lock Updated dependencies including kettle-dev, removed vcr/webmock related gems
.yardopts Enhanced YARD configuration with new plugins and fence support
Documentation HTML files in docs/ Regenerated documentation with new YARD docs
README.md, CHANGELOG.md, FUNDING.md, CONTRIBUTING.md Minor content and formatting updates
Files not reviewed (1)
  • .idea/.gitignore: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pboling pboling merged commit 31a8654 into main Nov 10, 2025
42 of 43 checks passed
@pboling pboling deleted the feat/cleanup branch November 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants