Refactor SAML SLO specs into dedicated describe blocks #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardo-navarro
commented
Nov 3, 2025
Contributor
Author
gerardo-navarro
left a comment
gerardo-navarro
left a comment
There was a problem hiding this comment.
@bufferoverflow Hi 👋 Can you please have a look at this small refactoring that makes the tests more readable.
bufferoverflow
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test organization in saml_spec.rb by extracting nested contexts for logout-related endpoints into separate top-level describe blocks, improving test structure and readability.
- Extracts
/auth/saml/slotests into a dedicateddescribeblock - Extracts
/auth/saml/spslotests into a dedicateddescribeblock - Consolidates shared setup (
sp_entity_id) at appropriate scope levels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fh1ch
approved these changes
Nov 3, 2025
Contributor
fh1ch
left a comment
fh1ch
left a comment
There was a problem hiding this comment.
@gerardo-navarro much appreciated, thanks a ton for the refactoring 🙇
LGTM 👍
gerardo-navarro
deleted the
gerardo-navarro-refactor-saml-specs-for-logout-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bundle exec rspec spec/omniauth/strategies/saml_spec.rb