Clifm : add new recipe

[extrowerk]

Clifm is a nice terminal file manager: https://github.com/leo-arch/clifm

The patch is extracted from : leo-arch/clifm@8f8a7fc

[hadfl]

Thank you for your contribution. There are a few questions, please see below

[extrowerk]

Cmake dependency have been removed.

[extrowerk]

All issue have been fixed.

[citrus-it]

Thanks for putting this together! I just tried building the package locally with the changes in this PR, but the
resulting manifest ends up without any file actions — just the set and licence entries.

+set name=pkg.fmri value=pkg://extra.omnios/ooce/application/clifm
+set name=pkg.summary value=clifm
+set name=pkg.description value="A shell-like, text-based terminal file manager"
+set name=info.source-url value=https://mirrors.omnios.org/clifm/clifm-1.26.3.tar.gz
+set name=publisher value=sa@omnios.org
+license 24d892cae44e4d8279f44b2cf5c5bb07b047f3cd license=GPLv2

Is it possible something didn’t get pushed, or that you were testing with some additional local changes? If you have a known-good build environment or manifest, could you share that so we can reproduce it?

One thing that definitely doesn't look right is the

logcmd $gmake gmake -f misc/solaris/Makefile

which should presumably be this ($MAKE is gmake in the build framework)

logcmd $MAKE -f misc/solaris/Makefile 

Also, just a quick reminder of our minimalist principle (https://omnios.org/about/kysty) - we aim to package things that are broadly useful to the OmniOS community and that we can commit to maintaining across releases. If this is mostly for personal use, maintaining a small external repository might be a better route; if you think this has general appeal, happy to continue working through it with you.

[extrowerk]

Thanks for putting this together! I just tried building the package locally with the changes in this PR, but the resulting manifest ends up without any file actions — just the set and licence entries.

You have right, I missed some commits. Updated, now it should be ok.

Also, just a quick reminder of our minimalist principle (https://omnios.org/about/kysty) - we aim to package things that are broadly useful to the OmniOS community and that we can commit to maintaining across releases. If this is mostly for personal use, maintaining a small external repository might be a better route; if you think this has general appeal, happy to continue working through it with you.

I understand your point and I'll look into creating a personal repository.
I personally like both fish and clifm, and use on my OpenBSD machines. Clifm in my eyes a slim variant of "mc", it helps me to quickly explore the fodler structure, without standing between me and the terminal. I think it could be useful for other people aswell.

[hadfl]

When possible we try not to override the build framework. Could you instead use e.g.:

pre_configure() {
    typeset arch=$1

    subsume_arch $arch CFLAGS

    # No configure
    false
}


MAKE_ARGS="-f misc/solaris/Makefile"
MAKE_INSTALL_ARGS="$MAKE_ARGS INSTALL=install PREFIX=$PREFIX"

This will also make sure the CTF CFLAGS are used.

[extrowerk]

Done, thanks for the hint!

[extrowerk]

Bumped to 1.27

[extrowerk]

Bumped to 1.27.1.

I got this warning:

==== opt/ooce/bin/clifm ====
                unused search path=/usr/xpg4/lib/amd64  (RUNPATH/RPATH from file /usr/lib/64/libreadline.so.8)  <remove search path?>
        unreferenced object=/lib/64/libtermcap.so.1; unused dependency of /tmp/build_szilard/clifm-1.27.1/ooce_application_clifm_pkg/opt/ooce/bin/clifm <remove lib or -zignore?>
        unreferenced object=/lib/64/libm.so.2; unused dependency of /usr/lib/64/libmagic.so.1   <remove lib or -zignore?>
ELF runtime problems detected

Is there anything I can do to fix this?