Merge pull request cfpb#1128 from nickgrippin/v280-fix

V280 - filter out empty MSA/MDs

Author: jmarin

validation/src/main/scala/hmda/validation/rules/lar/validity/V280.scala

@@ -11,9 +11,9 @@ object V280 extends EditCheck[LoanApplicationRegister] {
 
   val cbsaTracts = CBSATractLookup.values
 
-  val validMSAs = cbsaTracts.map(cbsa => cbsa.geoIdMsa).toSet
+  val validMSAs = cbsaTracts.map(cbsa => cbsa.geoIdMsa).filterNot(msa => msa.isEmpty).toSet
 
-  val validMDs = cbsaTracts.map(cbsa => cbsa.metDivFp).toSet
+  val validMDs = cbsaTracts.map(cbsa => cbsa.metDivFp).filterNot(md => md.isEmpty).toSet
 
   override def name: String = "V280"
 

validation/src/test/scala/hmda/validation/rules/lar/validity/V280Spec.scala

@@ -38,5 +38,13 @@ class V280Spec extends LarEditCheckSpec {
     }
   }
 
+  property("Fails for a blank MSA code") {
+    forAll(larGen) { lar =>
+      val inValidGeography = lar.geography.copy(msa = "")
+      val inValidLar = lar.copy(geography = inValidGeography)
+      inValidLar.mustFail
+    }
+  }
+
   override def check: EditCheck[LoanApplicationRegister] = V280
 }