Merge pull request cfpb#1075 from jmarin/compiler-warnings

Compiler warnings

Author: schbetsy

api/src/main/scala/hmda/api/HmdaFilingApi.scala

@@ -1,15 +1,14 @@
 package hmda.api
 
-import akka.actor.{ ActorRef, ActorSystem, Props }
+import akka.actor.{ ActorSystem, Props }
 import akka.event.Logging
 import akka.http.scaladsl.Http
 import akka.http.scaladsl.Http.ServerBinding
 import akka.http.scaladsl.server.Directives._
 import akka.http.scaladsl.server.Route
-import akka.pattern.{ ask, pipe }
+import akka.pattern.pipe
 import akka.stream.ActorMaterializer
 import akka.util.Timeout
-import com.typesafe.config.ConfigFactory
 import hmda.api.http.{ BaseHttpApi, HmdaCustomDirectives, InstitutionsHttpApi, LarHttpApi }
 import hmda.api.HmdaConfig._
 import scala.concurrent.duration._

api/src/main/scala/hmda/api/HmdaPlatform.scala

@@ -24,7 +24,6 @@ import hmda.query.projections.filing.HmdaFilingDBProjection._
 import hmda.validation.ValidationStats
 import hmda.api.HmdaConfig._
 import hmda.query.HmdaProjectionQuery
-import hmda.query.projections.institutions.InstitutionCassandraProjection
 
 object HmdaPlatform {
 

api/src/main/scala/hmda/api/http/ValidationErrorConverter.scala

@@ -6,7 +6,6 @@ import hmda.model.edits.EditMetaDataLookup
 import hmda.model.fi.{ HmdaFileRow, HmdaRowError }
 import hmda.model.validation.ValidationError
 import hmda.persistence.processing.HmdaFileValidator.HmdaFileValidationState
-import hmda.validation.engine._
 import spray.json.{ JsNumber, JsObject, JsString, JsValue }
 
 trait ValidationErrorConverter {

api/src/main/scala/hmda/api/http/institutions/FilingPaths.scala

@@ -19,7 +19,7 @@ import hmda.persistence.HmdaSupervisor.{ FindFilings, FindSubmissions }
 import hmda.persistence.institutions.FilingPersistence.GetFilingByPeriod
 import hmda.persistence.institutions.{ FilingPersistence, SubmissionPersistence }
 
-import scala.concurrent.{ ExecutionContext, Future }
+import scala.concurrent.Future
 import scala.util.{ Failure, Success }
 
 trait FilingPaths extends InstitutionProtocol with ApiErrorProtocol with HmdaCustomDirectives {

api/src/main/scala/hmda/api/http/institutions/InstitutionPaths.scala

@@ -22,7 +22,7 @@ import hmda.persistence.model.HmdaSupervisorActor.FindActorByName
 import hmda.query.view.institutions.InstitutionView
 import hmda.query.view.institutions.InstitutionView.{ GetInstitutionById, GetInstitutionsById }
 
-import scala.concurrent.{ ExecutionContext, Future }
+import scala.concurrent.Future
 import scala.util.{ Failure, Success }
 
 trait InstitutionPaths extends InstitutionProtocol with ApiErrorProtocol with HmdaCustomDirectives {

api/src/main/scala/hmda/api/http/institutions/UploadPaths.scala

@@ -28,7 +28,6 @@ import hmda.persistence.processing.SubmissionManager
 import hmda.query.HmdaQuerySupervisor.FindHmdaFilingView
 import hmda.query.projections.filing.HmdaFilingDBProjection.{ CreateSchema, DeleteLars }
 
-import scala.concurrent.ExecutionContext
 import scala.util.{ Failure, Success }
 
 trait UploadPaths extends InstitutionProtocol with ApiErrorProtocol with SubmissionProtocol with HmdaCustomDirectives {

api/src/main/scala/hmda/api/http/institutions/submissions/SubmissionBasePaths.scala

@@ -12,15 +12,11 @@ import akka.util.Timeout
 import hmda.api.http.{ HmdaCustomDirectives, ValidationErrorConverter }
 import hmda.api.model._
 import hmda.api.protocol.processing.{ ApiErrorProtocol, EditResultsProtocol, InstitutionProtocol }
-import hmda.model.fi.{ Filing, Submission, SubmissionId }
-import hmda.model.validation.Macro
-import hmda.persistence.messages.CommonMessages.GetState
-import hmda.persistence.HmdaSupervisor.{ FindFilings, FindProcessingActor, FindSubmissions }
+import hmda.model.fi.{ Filing, Submission }
+import hmda.persistence.HmdaSupervisor.{ FindFilings, FindSubmissions }
 import hmda.persistence.institutions.FilingPersistence.GetFilingByPeriod
 import hmda.persistence.institutions.SubmissionPersistence.{ CreateSubmission, GetLatestSubmission }
 import hmda.persistence.institutions.{ FilingPersistence, SubmissionPersistence }
-import hmda.persistence.processing.HmdaFileValidator
-import hmda.persistence.processing.HmdaFileValidator.HmdaFileValidationState
 
 import scala.concurrent.ExecutionContext
 import scala.util.{ Failure, Success }

api/src/main/scala/hmda/api/http/institutions/submissions/SubmissionEditPaths.scala

@@ -4,7 +4,6 @@ import akka.actor.{ ActorRef, ActorSelection, ActorSystem }
 import akka.event.LoggingAdapter
 import akka.http.scaladsl.marshalling.ToResponseMarshallable
 import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
-import akka.http.scaladsl.model.Uri
 import akka.http.scaladsl.server.Directives._
 import akka.pattern.ask
 import akka.stream.ActorMaterializer
@@ -20,8 +19,6 @@ import hmda.persistence.institutions.SubmissionPersistence
 import hmda.persistence.institutions.SubmissionPersistence.GetSubmissionById
 import hmda.persistence.processing.{ HmdaFileValidator, SubmissionManager }
 import hmda.persistence.processing.HmdaFileValidator._
-import hmda.validation.engine._
-
 import scala.concurrent.{ ExecutionContext, Future }
 import scala.util.matching.Regex
 import scala.util.{ Failure, Success }

api/src/main/scala/hmda/api/http/institutions/submissions/SubmissionIrsPaths.scala

@@ -61,7 +61,7 @@ trait SubmissionIrsPaths
       }
     }
 
-  private def getMsa(instId: String, period: String, seqNr: Int)(implicit ec: ExecutionContext): Future[Seq[Msa]] = {
+  private def getMsa(instId: String, period: String, seqNr: Int): Future[Seq[Msa]] = {
     val validationStats = system.actorSelection("/user/validation-stats")
     val submissionId = SubmissionId(instId, period, seqNr)
     (validationStats ? FindIrsStats(submissionId)).mapTo[Seq[Msa]]

api/src/main/scala/hmda/api/http/institutions/submissions/SubmissionParseErrorsPaths.scala

@@ -19,7 +19,7 @@ import hmda.persistence.processing.HmdaFileParser.{ GetStatePaginated, Paginated
 import hmda.persistence.processing.HmdaFileParser
 
 import scala.concurrent.ExecutionContext
-import scala.util.{ Failure, Success, Try }
+import scala.util.{ Failure, Success }
 
 trait SubmissionParseErrorsPaths
     extends ParserResultsProtocol