Merge pull request cfpb#1125 from schbetsy/util-tests

Util tests

Author: Nick Grippin

persistence/src/main/scala/hmda/persistence/processing/HmdaFileValidator.scala

@@ -30,7 +30,7 @@ import hmda.persistence.messages.events.processing.HmdaFileValidatorEvents._
 import hmda.persistence.model.HmdaSupervisorActor.FindActorByName
 import hmda.persistence.processing.SubmissionManager.GetActorRef
 import hmda.validation.SubmissionLarStats
-import hmda.validation.SubmissionLarStats.{ PersistIrs, PersistStatsForMacroEdits }
+import hmda.validation.SubmissionLarStats.PersistStatsForMacroEdits
 import hmda.validation.ValidationStats.AddSubmissionTaxId
 
 import scala.util.Try

persistence/src/main/scala/hmda/persistence/processing/SubmissionManager.scala

@@ -8,7 +8,7 @@ import akka.util.Timeout
 import com.typesafe.config.ConfigFactory
 import hmda.model.fi.{ Signed => _, _ }
 import hmda.persistence.institutions.FilingPersistence
-import hmda.persistence.institutions.FilingPersistence.{ GetFilingByPeriod, UpdateFilingStatus }
+import hmda.persistence.institutions.FilingPersistence.UpdateFilingStatus
 import hmda.persistence.HmdaSupervisor.{ FindFilings, FindHmdaFiling }
 import hmda.persistence.messages.CommonMessages.{ Command, GetState, Shutdown }
 import hmda.persistence.model.HmdaActor

publication/src/main/scala/hmda/publication/reports/util/ReportUtil.scala

@@ -18,10 +18,13 @@ import scala.concurrent.Future
 object ReportUtil extends SourceUtils {
 
   def msaReport(fipsCode: String): MSAReport = {
-    val cbsa = CbsaLookup.values.find(x => x.cbsa == fipsCode).getOrElse(Cbsa())
-    val stateFips = cbsa.key.substring(0, 2)
-    val state = StateAbrvLookup.values.find(s => s.state == stateFips).getOrElse(StateAbrv("", "", ""))
-    MSAReport(fipsCode, CbsaLookup.nameFor(fipsCode), state.stateAbrv, state.stateName)
+    CbsaLookup.values.find(x => x.cbsa == fipsCode) match {
+      case Some(cbsa) =>
+        val stateFips = cbsa.key.substring(0, 2)
+        val state = StateAbrvLookup.values.find(s => s.state == stateFips).getOrElse(StateAbrv("", "", ""))
+        MSAReport(fipsCode, CbsaLookup.nameFor(fipsCode), state.stateAbrv, state.stateName)
+      case None => MSAReport("", "", "", "")
+    }
   }
 
   def calculateMedianIncomeIntervals(fipsCode: Int): Array[Double] = {

publication/src/test/scala/hmda/publication/reports/util/ReportUtilSpec.scala

@@ -0,0 +1,54 @@
+package hmda.publication.reports.util
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import akka.stream.scaladsl.Source
+import hmda.model.fi.lar.LarGenerators
+import hmda.model.publication.reports.MSAReport
+import hmda.publication.reports.util.ReportUtil._
+import hmda.query.repository.filing.LarConverter._
+import org.scalatest.{ AsyncWordSpec, MustMatchers }
+
+class ReportUtilSpec extends AsyncWordSpec with MustMatchers with LarGenerators {
+
+  implicit val system = ActorSystem()
+  implicit val ec = system.dispatcher
+  implicit val materializer = ActorMaterializer()
+
+  "msaReport" must {
+    "get MSA info for given fips code and return MSAReport object" in {
+      msaReport("10380") mustBe MSAReport("10380", "Aguadilla-Isabela, PR", "PR", "Puerto Rico")
+      msaReport("26980") mustBe MSAReport("26980", "Iowa City, IA", "IA", "Iowa")
+      msaReport("41100") mustBe MSAReport("41100", "St. George, UT", "UT", "Utah")
+    }
+
+    "Return empty MSAReport if fips code is invalid" in {
+      msaReport("bogus") mustBe MSAReport("", "", "", "")
+    }
+  }
+
+  "calculateMedianIncomeIntervals" must {
+    "get median income info for given fips, convert to thousands" in {
+      calculateMedianIncomeIntervals(10380)(2) mustBe 18.267
+      calculateMedianIncomeIntervals(26980)(2) mustBe 81.027
+      calculateMedianIncomeIntervals(41100)(2) mustBe 58.145
+    }
+    "return array of 50%, 80%, 100%, and 120% levels of median income (in thousands)" in {
+      def roundTo3(v: Double) = BigDecimal(v).setScale(3, BigDecimal.RoundingMode.HALF_UP).toDouble
+      calculateMedianIncomeIntervals(26980) mustBe Array(40.5135, 64.8216, 81.027, 97.2324)
+      calculateMedianIncomeIntervals(41100).map(roundTo3) mustBe Array(29.073, 46.516, 58.145, 69.774)
+    }
+  }
+
+  "calculateYear" must {
+    "given a larSource, return the Activity Year for the LARs in it" in {
+      // Activity Year is the same year as Action Taken Date. This is enforced by edit S270
+      val lars = larListGen.sample.get.map(_.copy(actionTakenDate = 20090822))
+      val src = Source.fromIterator(() => lars.toIterator)
+        .map(lar => toLoanApplicationRegisterQuery(lar))
+
+      calculateYear(src).map(_ mustBe 2009)
+    }
+  }
+
+}