Fixing zetaback erroring out when receiving FS is modified#3
Open
crazzy wants to merge 2 commits intoomniti-labs:masterfrom
Open
Fixing zetaback erroring out when receiving FS is modified#3crazzy wants to merge 2 commits intoomniti-labs:masterfrom
crazzy wants to merge 2 commits intoomniti-labs:masterfrom
Conversation
Author
|
Did another commit containing a fix for locking issues I've encountered on Solaris 11. Zetaback didn't even try taking backups of some datasets. After debugging with truss I found out the open() call on the directory failed with EISDIR. So in order to fix this I've made zetaback lock on a file instead. This has also been tested on the backup servers in our production environment with successful results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ran into this error again:
http://lists.omniti.com/pipermail/zetaback-users/2013-July/000053.html
I digged a bit deeper into this and it seems that the issue here is that something on the backup server (which receives the stream) has modified the the filesystem. In our case I'll take a guess that it's a default Solaris cronjob (nfsfind).
It's a very simple patch, just adding -F to the zfs recv command which I've tested on two backup servers in our production environment with successful results, both on backup jobs which showed this error, and on other backup jobs not showing the error.