Skip to content

change(api): reintroduce armasec domain config#941

Closed
fschuch wants to merge 5 commits intomainfrom
change/api--revert-armasec-domain-config
Closed

change(api): reintroduce armasec domain config#941
fschuch wants to merge 5 commits intomainfrom
change/api--revert-armasec-domain-config

Conversation

@fschuch
Copy link
Member

@fschuch fschuch commented Mar 12, 2026

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.39%. Comparing base (941c8b9) to head (ab0c0ae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
+ Coverage   93.38%   93.39%   +0.01%     
==========================================
  Files         108      108              
  Lines        5758     5772      +14     
==========================================
+ Hits         5377     5391      +14     
  Misses        381      381              
Flag Coverage Δ
agent 93.39% <ø> (ø)
api 95.74% <ø> (+0.02%) ⬆️
cli 89.05% <ø> (ø)
core 96.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fschuch fschuch force-pushed the change/api--revert-armasec-domain-config branch from 0499f97 to 3729c19 Compare March 12, 2026 09:04
@fschuch fschuch force-pushed the change/api--revert-armasec-domain-config branch from 3729c19 to ab0c0ae Compare March 12, 2026 09:09
@sonarqubecloud
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reintroduces support for configuring Armasec with multiple domain configurations (including an optional “admin” domain) via API settings, and adds unit tests to validate the domain-config selection behavior.

Changes:

  • Add ARMASEC_ADMIN_* settings to allow an optional admin Armasec domain gated by match key/value.
  • Introduce get_domain_configs() and switch the Armasec guard initialization to use domain_configs.
  • Add tests covering base-only and base+admin domain-config generation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
jobbergate-api/jobbergate_api/security.py Adds get_domain_configs() and initializes Armasec with domain_configs rather than a single domain.
jobbergate-api/jobbergate_api/config.py Adds optional ARMASEC_ADMIN_DOMAIN/MATCH_KEY/MATCH_VALUE settings fields.
jobbergate-api/tests/test_security.py Adds unit tests for get_domain_configs() behavior under different settings combinations.
changes/api/941.changed.md Adds a Towncrier changelog fragment describing the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fschuch
Copy link
Member Author

fschuch commented Mar 13, 2026

It looks like this change is not required anymore

@fschuch fschuch closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants