change(api): reintroduce armasec domain config#941
Conversation
This reverts commit 65e531f.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
+ Coverage 93.38% 93.39% +0.01%
==========================================
Files 108 108
Lines 5758 5772 +14
==========================================
+ Hits 5377 5391 +14
Misses 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0499f97 to
3729c19
Compare
3729c19 to
ab0c0ae
Compare
|
There was a problem hiding this comment.
Pull request overview
This PR reintroduces support for configuring Armasec with multiple domain configurations (including an optional “admin” domain) via API settings, and adds unit tests to validate the domain-config selection behavior.
Changes:
- Add
ARMASEC_ADMIN_*settings to allow an optional admin Armasec domain gated by match key/value. - Introduce
get_domain_configs()and switch the Armasecguardinitialization to usedomain_configs. - Add tests covering base-only and base+admin domain-config generation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| jobbergate-api/jobbergate_api/security.py | Adds get_domain_configs() and initializes Armasec with domain_configs rather than a single domain. |
| jobbergate-api/jobbergate_api/config.py | Adds optional ARMASEC_ADMIN_DOMAIN/MATCH_KEY/MATCH_VALUE settings fields. |
| jobbergate-api/tests/test_security.py | Adds unit tests for get_domain_configs() behavior under different settings combinations. |
| changes/api/941.changed.md | Adds a Towncrier changelog fragment describing the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It looks like this change is not required anymore |



No description provided.