Use bash, not sh, for local-exec interpreter#32
Merged
Conversation
This had worked fine locally, where I guess `sh` is symlinked to `bash`. However, real `sh` doesn't allow the `set -o pipefail`, so we need to use bash for this to deploy correctly in GitHub Actions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Terraform local-exec provisioners to run under bash rather than sh, ensuring set -euo pipefail works reliably in GitHub Actions and other environments where /bin/sh is not bash.
Changes:
- Switched
local-execinterpreter from["/bin/sh", "-c"]to["/bin/bash", "-c"]in the image build/publish/republish modules. - Aligns shell behavior with the scripts’ existing reliance on
pipefail.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/lambda-image-republish/main.tf | Use /bin/bash for the republish local-exec script so pipefail is supported. |
| modules/lambda-image-public/main.tf | Use /bin/bash for the public image build/push local-exec script. |
| modules/lambda-image-build/main.tf | Use /bin/bash for the private image build/push local-exec script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ethanholz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had worked fine locally, where I guess
shis symlinked tobash. However, realshdoesn't allow theset -o pipefail, so we need to use bash for this to deploy correctly in GitHub Actions.