DatabaseException при отсутствии соединения #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Да, наверное. |
|
Я - за. |
test/core/DbConnectionTest.class.php
Outdated
There was a problem hiding this comment.
<?php
$this->fail('Unreachable code');капельку наглядней должно быть
added 2 commits
June 28, 2012 19:37
|
Волью. Нам это нужно :) |
dovg
added a commit
that referenced
this pull request
Jun 29, 2012
DatabaseException при отсутствии соединения
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В данный момент при отсутствии соединения из-за error2exception выбрасывается BaseException. Правильнее выбрасывать DatabaseException.
Отмечу, что pg_errormessage() в данном контексте использоваться не может, потому что требует установленного соединения: