PrimitiveHstore export должен возвращать массив а не объект. #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавил тесты + в случае если во внутренней форме ошибки - export будет возвращать null. |
AlexeyDsov
added a commit
that referenced
this pull request
Aug 9, 2012
PrimitiveHstore::exportValue now return array instead of Hstore object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Как-то раньше в глаза не бросалось, но PrimitiveHstore::export так же как и другие примитивы по логике должен возвращать то, что можно использовать для import'а - то есть ассоциативный массив.
Сейчас он возвращает Hstore объекты.
Предлагаю вот такой вот фикс, т.к. API ломается, то попасть оно должно только в мастер.