Skip to content

fix non existing enumeration import #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

fix non existing enumeration import #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/Form/Primitives/PrimitiveEnumeration.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public function import($scope)
$this->value = new $this->className($this->value);
} catch (MissingElementException $e) {
$this->value = null;
$this->imported = false;

return false;
}
Expand Down
32 changes: 27 additions & 5 deletions test/core/PrimitiveEnumerationTest.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ final class PrimitiveEnumerationTest extends TestCase
{
public function testIntegerValues()
{
$form =
Form::create()->
add(
Primitive::enumeration('enum')->of('DataType')
);
$form = $this->getForm();

$form->import(array('enum' => '4097'));

Expand All @@ -30,5 +26,31 @@ public function testGetList()
$primitive->import(array('enum' => DataType::getAnyId()));
$this->assertEquals($primitive->getList(), $enum->getObjectList());
}

public function testNonExsitingValue()
{
$form = $this->getForm();

$form->get('enum')->
setDefault(DataType::create(DataType::getAnyId()));

$form->import(array('enum' => -10000));

$this->assertFalse($form->get('enum')->isImported());
$this->assertNull($form->getValue('enum'));
$this->assertEquals(
DataType::getAnyId(),
$form->getActualValue('enum')->getId()
);
}

private function getForm()
{
return
Form::create()->
add(
Primitive::enumeration('enum')->of('DataType')
);
}
}
?>