Skip to content

ID-15: Fix asymmetric invalid refresh token test#741

Merged
karlnaden merged 1 commit intoonc-healthit:mainfrom
abhinandan2012:ID-15-asymmetric-refresh-token-auth
Feb 6, 2026
Merged

ID-15: Fix asymmetric invalid refresh token test#741
karlnaden merged 1 commit intoonc-healthit:mainfrom
abhinandan2012:ID-15-asymmetric-refresh-token-auth

Conversation

@abhinandan2012
Copy link
Contributor

Description

This PR addresses Issue #700 by fixing the SMARTInvalidTokenRefreshTest to support asymmetric authentication. Previously, the test did not interpret the asymmetric auth type correctly and failed to send the required client_assertion and client_assertion_type parameters. This meant the test was effectively checking unauthenticated behavior rather than authenticated asymmetric behavior.

Changes

  • Modified
    lib/onc_certification_g10_test_kit/smart_invalid_token_refresh_test.rb to use SMARTAppLaunch::ClientAssertionBuilder for generating the client assertion when asymmetric auth is configured. Updated spec/onc_certification_g10_test_kit/smart_invalid_token_refresh_test_spec.rb with a new context to verify the presence of client assertion parameters in the request.

  • Updated
    spec/onc_certification_g10_test_kit/smart_invalid_token_refresh_test_spec.rb with a new context to verify the presence of client assertion parameters in the request.

End-to-End Testing Steps

  1. Start Inferno:

    • Launch the onc-certification-g10-test-kit instance.
  2. Select Options:

    • On the home page, select US Core 6.1.0 / USCDI v3.
    • Select SMART App Launch 2.0.0.
    • Select Bulk Data 1.0.1.
    • Click START TESTING button.
  3. Select Preset:

    • In the top-left corner of the test session, locate the Preset dropdown.
    • Select Inferno Reference Server Preset.
    • This will auto-populate the necessary configuration fields.
  4. Navigate to Test:

    • Expand 9 Additional Authorization Tests in the left sidebar.
    • Expand 9.12 Asymmetric Client Launch.
    • Expand 9.12.3 Token Refresh.
  5. Run Test:

    • Click the RUN TESTS button in the top right.
    • Action: In the Asymmetric Client Standalone Launch modal that appears, click the Submit button (inputs are pre-filled by the preset).
  6. Verify:

    • Ensure test 9.12.3.06 PASSES.
    • Click on the 9.12.3.06 test result to expand details.
    • Check the Requests tab for the POST to the token endpoint.
    • Confirm the request body includes client_assertion and client_assertion_type.

@karlnaden karlnaden self-requested a review January 30, 2026 15:35
@karlnaden karlnaden merged commit 4d7bb1a into onc-healthit:main Feb 6, 2026
4 checks passed
@karlnaden karlnaden changed the title Fix asymmetric invalid refresh token test ID-15: Fix asymmetric invalid refresh token test Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants