Open
Conversation
one-harsh
reviewed
Nov 28, 2019
Owner
one-harsh
left a comment
one-harsh
left a comment
There was a problem hiding this comment.
Would probably also need a new API called mythread() in defs.h.
|
|
||
| // t->lock must be held when using these: | ||
| int tid; | ||
| enum procstate state; |
Owner
There was a problem hiding this comment.
We don't need this. We need a pointer to parent proc itself.
|
|
||
| enum procstate { UNUSED, SLEEPING, RUNNABLE, RUNNING, ZOMBIE }; | ||
|
|
||
| struct thread |
|
|
||
|
|
||
| // Per-process state | ||
| struct proc { |
one-harsh
reviewed
Nov 28, 2019
| struct thread *tcb; | ||
| struct threadlist *next; | ||
| }; | ||
|
|
Owner
There was a problem hiding this comment.
While the fancy list is nice and gives a container like ability, but let's keep things simple for now and just use an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.