Skip to content

[SYCLomatic] Fixing dpct::device_vector usage in copy_if test #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SYCLomatic] Fixing dpct::device_vector usage in copy_if test #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0685a
fixing device_vector usage
danhoeflinger Feb 22, 2023
1d9c3c2
removing comment describing runtime failure
danhoeflinger Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions help_function/src/onedpl_test_copy_if.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,31 +226,19 @@ int main() {
// dcpt::copy_if with device_vector

{
// **FAILS AT RUNTIME**

// create src and dst device_vector
dpct::device_vector<int> src_dv(8);
dpct::device_vector<int> dst_dv(8);
std::vector<int> src_vec(8);
std::vector<int> dst_vec(8);


for (int i = 0; i != 8; ++i) {
src_vec[i] = i;
dst_vec[i] = 0;
}

//copy from src_vec to src_dv
dpct::get_default_queue().submit([&](sycl::handler& h) {
h.memcpy(src_dv.data(), src_vec.data(), 8 * sizeof(int));
});
dpct::get_default_queue().wait();

//copy from dst_vec to dst_dv
dpct::get_default_queue().submit([&](sycl::handler& h) {
h.memcpy(dst_dv.data(), dst_vec.data(), 8 * sizeof(int));
});
dpct::get_default_queue().wait();

dpct::device_vector<int> src_dv(src_vec);
dpct::device_vector<int> dst_dv(dst_vec);
// src_dv: { 0, 1, 2, 3, 4, 5, 6, 7 }
// dst_dv: { 0, 0, 0, 0, 0, 0, 0, 0 }

Expand All @@ -269,22 +257,16 @@ int main() {
);
}

dpct::get_default_queue().submit([&](sycl::handler& h) {
// copy from dst_dv back to dst_vec
h.memcpy(dst_vec.data(), dst_dv.data(), 8 * sizeof(int));
});
dpct::get_default_queue().wait();

std::string test_name = "copy_if with device_vector";

// expected dst_vec: { 5, 7, 0, 0, 0, 0, 0, 0 }
for (int i = 0; i != 8; ++i) {
if (i == 0)
num_failing += ASSERT_EQUAL(test_name, dst_vec[i], 5);
num_failing += ASSERT_EQUAL(test_name, dst_dv[i], 5);
else if (i == 1)
num_failing += ASSERT_EQUAL(test_name, dst_vec[i], 7);
num_failing += ASSERT_EQUAL(test_name, dst_dv[i], 7);
else
num_failing += ASSERT_EQUAL(test_name, dst_vec[i], 0);
num_failing += ASSERT_EQUAL(test_name, dst_dv[i], 0);
}

failed_tests += test_passed(num_failing, test_name);
Expand Down