Skip to content
This repository was archived by the owner on Sep 22, 2025. It is now read-only.

Conversation

quazuo
Copy link
Contributor

@quazuo quazuo commented Jul 31, 2024

No description provided.

@quazuo quazuo requested a review from mateuszpn August 2, 2024 17:43
Copy link
Contributor

@mateuszpn mateuszpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying my comments. Yet another issues - small in the implementation, more general in tests.

@quazuo quazuo requested a review from mateuszpn August 5, 2024 16:58
Copy link
Contributor

@lslusarczyk lslusarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mateusz comments applied well.
One more comment. Rest OK.

@quazuo quazuo requested a review from lslusarczyk August 16, 2024 11:14
@lslusarczyk
Copy link
Contributor

@quazuo , please merge this change with latest changes on the main, because you need to catch latest changes in CI

@lslusarczyk
Copy link
Contributor

fails because of bug in oneDPL, waiting for uxlfoundation/oneDPL#1834

@lslusarczyk
Copy link
Contributor

Now mp-tests do not link.

/usr/bin/ld: /tmp/icpx-d64b1ab94b/all-f158ad.o: in function `oneapi::dpl::__ranges::__select_backend(oneapi::dpl::execution::v1::sequenced_policy)':
all-fdd6ea.cpp:(.text+0x0): multiple definition of `oneapi::dpl::__ranges::__select_backend(oneapi::dpl::execution::v1::sequenced_policy)'; /tmp/icpx-d64b1ab94b/mp-tests-fac318.o:mp-tests-0cb7bc.cpp:(.text+0x0): first defined here

Is this problem in our code, your PR, or again in oneDPL?

@lslusarczyk lslusarczyk dismissed mateuszpn’s stale review September 11, 2024 09:46

Mateusz comments already applied

@lslusarczyk
Copy link
Contributor

Now mp-tests do not link.

/usr/bin/ld: /tmp/icpx-d64b1ab94b/all-f158ad.o: in function `oneapi::dpl::__ranges::__select_backend(oneapi::dpl::execution::v1::sequenced_policy)':
all-fdd6ea.cpp:(.text+0x0): multiple definition of `oneapi::dpl::__ranges::__select_backend(oneapi::dpl::execution::v1::sequenced_policy)'; /tmp/icpx-d64b1ab94b/mp-tests-fac318.o:mp-tests-0cb7bc.cpp:(.text+0x0): first defined here

Is this problem in our code, your PR, or again in oneDPL?

Not a problem with this PR but general in DR or oneDPL. The same failure is seen in #833

@lslusarczyk
Copy link
Contributor

[...]

Is this problem in our code, your PR, or again in oneDPL?

Not a problem with this PR but general in DR or oneDPL. The same failure is seen in #833

Fixed in uxlfoundation/oneDPL#1849
This was a problem in oneDPL.

@lslusarczyk
Copy link
Contributor

@quazuo , please again merge this change with latest changes on the main. Timeouts were increased and CI should pass on your change now

@lslusarczyk lslusarczyk enabled auto-merge (squash) September 27, 2024 08:02
@lslusarczyk lslusarczyk merged commit 02bbffb into oneapi-src:main Sep 27, 2024
4 checks passed
@quazuo quazuo deleted the count branch September 27, 2024 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants