Skip to content

Conversation

@vishnu-khanth
Copy link
Contributor

Related:To: VLCLJ-2335

@AshwinKumarKulkarni
Copy link
Contributor

change title to "adds combination of legacy and zesInit based sysman inititalization tests"

@vishnu-khanth vishnu-khanth changed the title test: Add different combination of Sysman init CTS Add combinations of legacy & zesInit based Sysman Init tests Nov 12, 2024
@vishnu-khanth
Copy link
Contributor Author

change title to "adds combination of legacy and zesInit based sysman inititalization tests"

Updated the title & commit msg !

Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@shreyaskunder
Copy link
Contributor

Is this okay if we add all the test cases in one file/binary? This would be okay if each test case is executed one by one using g_test filter. What if I run all the testcases without the gtest filter. In that scenario the first testcase's zeInit/zesInit would be valid for all the remaining testcases.

@vishnu-khanth
Copy link
Contributor Author

Is this okay if we add all the test cases in one file/binary? This would be okay if each test case is executed one by one using g_test filter. What if I run all the testcases without the gtest filter. In that scenario the first testcase's zeInit/zesInit would be valid for all the remaining testcases.

Yes, previously we had only 3 init tests. Hence, we had each test case as separate executable.
Since the number of tests has increased now, having separate executable for each test doesn't seem to be good scalable approach.

However, in CI each test is run as separate process with gtest_filter. Hence from CI point of view it will be fine.
Will be re looking into this how to refactor later as separate task.

Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
Related-To: VLCLJ-2335

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
Copy link
Contributor Author

Reordered the tests for better understanding of different combinations!

@vishnu-khanth vishnu-khanth deleted the cts_sysman_init branch December 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants