Skip to content

Fix: fixes the seg fault in the below frequency sysman test #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: fixes the seg fault in the below frequency sysman test #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions conformance_tests/sysman/test_sysman_frequency/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ add_lzt_test(
sysman_matrix_multiplication
DEFINES USE_ZESINIT
)

add_definitions(-DMATRIX_MUL_SPV_PATH="${CMAKE_SOURCE_DIR}/conformance_tests/sysman/test_sysman_frequency/kernels/sysman_matrix_multiplication.spv")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot work properly - MATRIX_MUL_SPV_PATH will be invalid after installation. Please see add_lzt_test cmake function and how KERNELS specifier works.

12 changes: 6 additions & 6 deletions conformance_tests/sysman/test_sysman_frequency/src/test_sysman_frequency.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,9 @@ void load_for_gpu(ze_device_handle_t target_device) {
void *a_buffer = lzt::allocate_host_memory(m * k * sizeof(float));
void *b_buffer = lzt::allocate_host_memory(k * n * sizeof(float));
void *c_buffer = lzt::allocate_host_memory(m * n * sizeof(float));
ze_module_handle_t module =
lzt::create_module(device, "sysman_matrix_multiplication.spv",
ZE_MODULE_FORMAT_IL_SPIRV, nullptr, nullptr);
std::string spv_path = std::string(MATRIX_MUL_SPV_PATH);
ze_module_handle_t module = lzt::create_module(
device, spv_path.c_str(), ZE_MODULE_FORMAT_IL_SPIRV, nullptr, nullptr);
ze_kernel_handle_t function =
lzt::create_function(module, "sysman_matrix_multiplication");
lzt::set_group_size(function, 16, 16, 1);
Expand Down Expand Up @@ -649,9 +649,9 @@ void loadForGpuMaxFreqTest(ze_device_handle_t target_device) {
void *a_buffer = lzt::allocate_host_memory(m * k * sizeof(float));
void *b_buffer = lzt::allocate_host_memory(k * n * sizeof(float));
void *c_buffer = lzt::allocate_host_memory(m * n * sizeof(float));
ze_module_handle_t module =
lzt::create_module(device, "sysman_matrix_multiplication.spv",
ZE_MODULE_FORMAT_IL_SPIRV, nullptr, nullptr);
std::string spv_path = std::string(MATRIX_MUL_SPV_PATH);
ze_module_handle_t module = lzt::create_module(
device, spv_path.c_str(), ZE_MODULE_FORMAT_IL_SPIRV, nullptr, nullptr);
ze_kernel_handle_t function =
lzt::create_function(module, "sysman_matrix_multiplication");
lzt::set_group_size(function, 16, 16, 1);
Expand Down
Loading