test(Sysman): Test to validate memory bandwidth counters with workload #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviralni
force-pushed
the
mem_cts
branch
3 times, most recently
from
3bb33d2 to
234576d
Compare
vishnu-khanth
requested review from
bellekal,
pratikbariintel,
anvesh-intel and
vishnu-khanth
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
anvesh-intel
reviewed
Jun 3, 2025
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
aviralni
force-pushed
the
mem_cts
branch
2 times, most recently
from
7c5d16c to
8dfacd5
Compare
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
Related-To: VLCLJ-2505 Signed-off-by: Aviral Nigam <[email protected]>
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
|
@aviralni Is this test expected to pass in all platforms? |
Related-To: VLCLJ-2505 Signed-off-by: Aviral Nigam <[email protected]>
Related-To: VLCLJ-2505 Signed-off-by: Aviral Nigam <[email protected]>
Related-To: VLCLJ-2505 Signed-off-by: Aviral Nigam <[email protected]>
aviralni
commented
Jun 13, 2025
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
| LOG_INFO << "Percentage Bandwidth: " << percentage_bandwidth << "%"; | ||
| EXPECT_GT(percentage_bandwidth, 0.0) | ||
| << "Percentage bandwidth is not greater than zero"; | ||
| EXPECT_LT(percentage_bandwidth, 100.0) |
There was a problem hiding this comment.
is it possible to reach 100% utilization?
conformance_tests/sysman/test_sysman_memory/src/test_sysman_memory.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| // Get initial bandwidth counters | ||
| auto bandwidth_before = lzt::get_mem_bandwidth(mem_handle); | ||
| EXPECT_LT(bandwidth_before.readCounter, UINT64_MAX); |
There was a problem hiding this comment.
readCounter & WriteCounter < UNIT64_MAX checks may not be useful.
maxBandWidth & timestamp can be checked if it's greater than 0. (Instead of checking < UNIT64_MAX )
There was a problem hiding this comment.
Actually, these checks were already present for counters validation, so did not modify these. IMO too we can modify these checks.
Related-To: VLCLJ-2505 Signed-off-by: Aviral Nigam <[email protected]>
|
LGTM. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2505