Skip to content

fix: calculate correct timestamp mask in case timestamp bitsequal size of timestamp type #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: calculate correct timestamp mask in case timestamp bitsequal size of timestamp type #262

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
731e748
fix: calculate correct timestamp mask in case timestamp bitsequal siz…
MaciejPlewka Aug 5, 2025
edfdc8f
fix: calculate correct timestamp mask in case timestamp bits equal si…
MaciejPlewka Aug 5, 2025
cbb98b8
fix: calculate correct timestamp mask in case timestamp bitsequal siz…
MaciejPlewka Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions perf_tests/ze_peak/src/ze_peak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ static void generic_uuid_to_string(const uint8_t *id, int bytes, char *s) {
*s = '\0';
}

template <typename T>
static void calculate_timestamp_mask(T &timestamp_mask,
uint32_t timestamp_bits) {
if (timestamp_bits >= sizeof(T) * CHAR_BIT) {
timestamp_mask = std::numeric_limits<T>::max();
} else {
timestamp_mask = (1ULL << timestamp_bits) - 1;
}
}

//---------------------------------------------------------------------
// Utility function to print the device properties from zeDeviceGetProperties.
//---------------------------------------------------------------------
Expand Down Expand Up @@ -1303,7 +1313,8 @@ long double ZePeak::run_kernel(L0Context context, ze_kernel_handle_t &function,
}

// don't know if this is correct. seems a little odd.
uint64_t timestamp_mask = (1ull << timestamp_bits) - 1;
uint64_t timestamp_mask = 0;
calculate_timestamp_mask(timestamp_mask, timestamp_bits);
uint64_t masked_device_time = device_timestamp & timestamp_mask;
uint64_t masked_kernel_time =
kernel_timestamp.global.kernelStart & timestamp_mask;
Expand Down Expand Up @@ -1485,7 +1496,8 @@ long double ZePeak::run_kernel(L0Context context, ze_kernel_handle_t &function,
std::to_string(result));
}

uint64_t timestamp_mask = (1ull << timestamp_bits) - 1;
uint64_t timestamp_mask = 0;
calculate_timestamp_mask(timestamp_mask, timestamp_bits);
uint64_t masked_device_time = device_timestamp & timestamp_mask;
uint64_t masked_kernel_time =
kernel_timestamp.global.kernelStart & timestamp_mask;
Expand Down
Loading