-
Notifications
You must be signed in to change notification settings - Fork 66
Fix: Handling GTEST_FAIL logic for multi-device scenario for LED, Memory and Firmware modules #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handling GTEST_FAIL logic for multi-device scenario for LED, Memory and Firmware modules #267
Conversation
Sub-tasks: VLCLJ-2572, VLCLJ-2575, VLCLJ-2564 Update the GTEST_FAIL logic for led, memory and firmware devices. Implemented to check the handles for all the devices and FAIL only if the handle is not found for any device. Signed-off-by: viki435 <[email protected]>
typos needs to be corrected |
Commit msg should be Fix: Handling GTEST_FAIL logic for multi-device scenario for LED, Memory and Firmware modules jira details should be in commit msg meta data |
Can this PR be divided into 3 separate PRs(1 for each module) if the changes in each modules are independent of each other? |
…fabric and overclocking modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the GTEST_FAIL logic for multi-device scenarios in LED, Memory, and Firmware test modules. The update changes the behavior from immediately failing when no handles are found on any single device to only failing if no handles are found across all devices.
- Implemented per-test class boolean flags to track if any device supports the tested functionality
- Changed the failure logic to log warnings for individual devices without handles and only fail if no devices have handles
- Updated code formatting for improved readability in several test methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
test_sysman_memory.cpp | Added is_mem_supported flag and updated all memory tests to check handles across all devices before failing |
test_sysman_led.cpp | Added is_led_supported flag and updated all LED tests to check handles across all devices before failing |
test_sysman_firmware.cpp | Added is_firmware_supported flag and updated all firmware tests to check handles across all devices before failing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
conformance_tests/sysman/test_sysman_firmware/src/test_sysman_firmware.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2572, VLCLJ-2575, VLCLJ-2564
Update the GTEST_FAIL logic for led, memory and firmware modules. Implemented to check the handles for all the devices and FAIL only if the handle is not found for any device.