Skip to content

Conversation

viki435
Copy link
Contributor

@viki435 viki435 commented Aug 11, 2025

Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2572, VLCLJ-2575, VLCLJ-2564
Update the GTEST_FAIL logic for led, memory and firmware modules. Implemented to check the handles for all the devices and FAIL only if the handle is not found for any device.

Sub-tasks: VLCLJ-2572, VLCLJ-2575, VLCLJ-2564
Update the GTEST_FAIL logic for led, memory and firmware devices.
Implemented to check the handles for all the devices and
FAIL only if the handle is not found for any device.

Signed-off-by: viki435 <[email protected]>
@vishnu-khanth
Copy link
Contributor

Primary JIRA: VLCJ-2513 Sub-tasks: VLCLJ-2572, VLCLJ-2575, VLCLJ-2564 Update the GTEST_FAIL logic for led, memory and firmware devices. Implemented to check the handles for all the devices and FAIL only if the handle is not found for any device.

typos needs to be corrected

@vishnu-khanth vishnu-khanth requested a review from Copilot August 11, 2025 06:22
Copilot

This comment was marked as outdated.

@vishnu-khanth
Copy link
Contributor

Commit msg should be Fix: Handling GTEST_FAIL logic for multi-device scenario for LED, Memory and Firmware modules

jira details should be in commit msg meta data

@anvesh-intel
Copy link
Contributor

Can this PR be divided into 3 separate PRs(1 for each module) if the changes in each modules are independent of each other?

Copilot

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

@vishnu-khanth vishnu-khanth requested a review from Copilot August 19, 2025 09:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the GTEST_FAIL logic for multi-device scenarios in LED, Memory, and Firmware test modules. The update changes the behavior from immediately failing when no handles are found on any single device to only failing if no handles are found across all devices.

  • Implemented per-test class boolean flags to track if any device supports the tested functionality
  • Changed the failure logic to log warnings for individual devices without handles and only fail if no devices have handles
  • Updated code formatting for improved readability in several test methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test_sysman_memory.cpp Added is_mem_supported flag and updated all memory tests to check handles across all devices before failing
test_sysman_led.cpp Added is_led_supported flag and updated all LED tests to check handles across all devices before failing
test_sysman_firmware.cpp Added is_firmware_supported flag and updated all firmware tests to check handles across all devices before failing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@vishnu-khanth vishnu-khanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AshwinKumarKulkarni AshwinKumarKulkarni merged commit 7027d05 into oneapi-src:master Aug 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants