-
Notifications
You must be signed in to change notification settings - Fork 66
Fix: Handling GTEST_FAIL logic for multi-device scenario for Engine, Fabric and Overclocking modules #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handling GTEST_FAIL logic for multi-device scenario for Engine, Fabric and Overclocking modules #270
Conversation
Sub-tasks: VLCLJ-2563, VLCLJ-2565, VLCLJ-2566 Fix: Handling GTEST_FAIL logic for multi-device scenario for engine, fabric and overclocking modules. Signed-off-by: viki435 <[email protected]>
conformance_tests/sysman/test_sysman_overclocking/src/test_sysman_overclocking.cpp
Outdated
Show resolved
Hide resolved
conformance_tests/sysman/test_sysman_overclocking/src/test_sysman_overclocking.cpp
Outdated
Show resolved
Hide resolved
Sub-tasks: VLCLJ-2573, VLCLJ-2569, VLCLJ-2571 Fix: Handling GTEST_FAIL logic for multi-device scenario for engine, fabric and overclocking modules. Signed-off-by: viki435 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes handling of GTEST_FAIL logic for multi-device scenarios in the Engine, Fabric, and Overclocking test modules. The changes address an issue where tests would fail immediately if any single device didn't support the required features, even when other devices in the system might support them.
- Replaced immediate FAIL() calls with device-specific checks and logging
- Added class member variables to track feature support across all devices
- Moved final FAIL() logic outside device loops to only fail if no devices support the feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
test_sysman_overclocking.cpp | Added is_frequency_supported flag and restructured tests to check all devices before failing |
test_sysman_fabric.cpp | Added is_fabric_supported flag and restructured tests to check all devices before failing |
test_sysman_engine.cpp | Added is_engine_supported flag and restructured tests to check all devices before failing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
conformance_tests/sysman/test_sysman_overclocking/src/test_sysman_overclocking.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2573, VLCLJ-2569, VLCLJ-2571
Fix: Handling GTEST_FAIL logic for multi-device scenario for engine, fabric and overclocking modules.