Skip to content

Conversation

viki435
Copy link
Contributor

@viki435 viki435 commented Aug 11, 2025

Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2573, VLCLJ-2569, VLCLJ-2571
Fix: Handling GTEST_FAIL logic for multi-device scenario for engine, fabric and overclocking modules.

Sub-tasks: VLCLJ-2563, VLCLJ-2565, VLCLJ-2566
Fix: Handling GTEST_FAIL logic for multi-device scenario for
engine, fabric and overclocking modules.

Signed-off-by: viki435 <[email protected]>
Copilot

This comment was marked as outdated.

@vishnu-khanth vishnu-khanth requested a review from Copilot August 18, 2025 12:20
Copilot

This comment was marked as outdated.

@vishnu-khanth vishnu-khanth requested a review from Copilot August 19, 2025 09:14
Copilot

This comment was marked as outdated.

Sub-tasks: VLCLJ-2573, VLCLJ-2569, VLCLJ-2571
Fix: Handling GTEST_FAIL logic for multi-device scenario for engine,
fabric and overclocking modules.

Signed-off-by: viki435 <[email protected]>
@vishnu-khanth vishnu-khanth requested a review from Copilot August 22, 2025 07:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes handling of GTEST_FAIL logic for multi-device scenarios in the Engine, Fabric, and Overclocking test modules. The changes address an issue where tests would fail immediately if any single device didn't support the required features, even when other devices in the system might support them.

  • Replaced immediate FAIL() calls with device-specific checks and logging
  • Added class member variables to track feature support across all devices
  • Moved final FAIL() logic outside device loops to only fail if no devices support the feature

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test_sysman_overclocking.cpp Added is_frequency_supported flag and restructured tests to check all devices before failing
test_sysman_fabric.cpp Added is_fabric_supported flag and restructured tests to check all devices before failing
test_sysman_engine.cpp Added is_engine_supported flag and restructured tests to check all devices before failing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@vishnu-khanth vishnu-khanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@viki435 viki435 requested a review from narenbagria August 25, 2025 10:54
@narenbagria narenbagria merged commit dfcaee5 into oneapi-src:master Aug 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants