Skip to content

fix: shared system atomic access attribute test #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bibrak merged 3 commits into from
Oct 2, 2025
Merged

fix: shared system atomic access attribute test #304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2542129
fix: shared system atomic access attribute test
narenbagria Oct 1, 2025
1d75bd2
fix: shared system atomic access attribute test
narenbagria Oct 1, 2025
a4479bd
fix: shared system atomic access attribute test
narenbagria Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions conformance_tests/core/test_usm/src/test_usm_atomic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,14 +307,13 @@ LZT_TEST_F(AtomicAccessTests, SetAndGetAccessTypeForSharedAllocation) {
lzt::free_memory(context, alloc_data);
}

LZT_TEST_F(AtomicAccessTests,
SetAndGetPositiveAccessTypeWithSharedSystemAllocator) {
SKIP_IF_SHARED_SYSTEM_ALLOC_UNSUPPORTED();
static void RunSetAndGetPositiveAccessTypeTest(bool is_shared_system) {
auto context = lzt::get_default_context();
auto device = lzt::get_default_device(lzt::get_default_driver());

auto alloc_data =
static_cast<int *>(lzt::aligned_malloc(size * sizeof(int), 1));
static_cast<int *>(lzt::allocate_shared_memory_with_allocator_selector(
size * sizeof(int), is_shared_system));

auto memory_access_properties = lzt::get_memory_access_properties(device);
ze_memory_atomic_attr_exp_flags_t access_type;
Expand Down Expand Up @@ -352,16 +351,26 @@ LZT_TEST_F(AtomicAccessTests,
context, device, alloc_data, size,
ZE_MEMORY_ATOMIC_ATTR_EXP_FLAG_SYSTEM_ATOMICS);

if (!(memory_access_properties.sharedSingleDeviceAllocCapabilities &
ZE_MEMORY_ACCESS_CAP_FLAG_CONCURRENT_ATOMIC)) {
auto capabilities =
is_shared_system
? memory_access_properties.sharedSystemAllocCapabilities
: memory_access_properties.sharedSingleDeviceAllocCapabilities;

if (!(capabilities & ZE_MEMORY_ACCESS_CAP_FLAG_CONCURRENT_ATOMIC)) {
EXPECT_EQ(ZE_RESULT_ERROR_INVALID_ARGUMENT, result);
} else {
EXPECT_ZE_RESULT_SUCCESS(result);
EXPECT_ZE_RESULT_SUCCESS(zeMemGetAtomicAccessAttributeExp(
context, device, alloc_data, size, &access_type));
EXPECT_EQ(ZE_MEMORY_ATOMIC_ATTR_EXP_FLAG_SYSTEM_ATOMICS, access_type);
}
lzt::aligned_free(alloc_data);
lzt::free_memory_with_allocator_selector(alloc_data, is_shared_system);
}

LZT_TEST_F(AtomicAccessTests,
SetAndGetPositiveAccessTypeWithSharedSystemAllocator) {
SKIP_IF_SHARED_SYSTEM_ALLOC_UNSUPPORTED();
RunSetAndGetPositiveAccessTypeTest(true);
}

} // namespace
Loading