Add opaque host memory allocation IPC test #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <eric.mortensen@intel.com>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <eric.mortensen@intel.com>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <eric.mortensen@intel.com>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <eric.mortensen@intel.com>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <eric.mortensen@intel.com>
aravindksg
reviewed
Oct 8, 2025
nrspruit
approved these changes
Oct 9, 2025
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
This looks good to me, @aravindksg you can give final approval, but due to the differences the new helper function is easier to read even if it duplicates some of the code.
Contributor
sounds good thanks, other than that changes lgtm |
aravindksg
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new tests for allocating opaque host memory for IPC.
Related-To: NEO-15836