Fix cts to validate scratch register. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviralni
commented
Oct 14, 2024
| @@ -16,8 +16,8 @@ namespace fs = boost::filesystem; | |||
| namespace bp = boost::process; | |||
| namespace bi = boost::interprocess; | |||
|
|
|||
| const uint16_t eventsTimeoutMS = 30000; | |||
There was a problem hiding this comment.
will remove this in final patch. For testing purpose used this.
|
I do not understand what this PR is doing. Is this supposed to be implementing VLCLJ-2302 ? That implementation should be done in the other tests repo, and should just be some minor changes to existing scratch test. SLM does not have anything to do with scratch - they are separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.