Skip to content

Reduce impact of tracing layer enabled with no tracers #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nrspruit wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Reduce impact of tracing layer enabled with no tracers #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions source/layers/tracing/tracing_imp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class APITracerCallbackDataImp {
currentTracerArray = \
(tracing_layer::tracer_array_t *) \
tracing_layer::pGlobalAPITracerContextImp->getActiveTracersList(); \
if (currentTracerArray) { \
if (currentTracerArray && currentTracerArray->tracerArrayCount > 0) { \
for (size_t i = 0; i < currentTracerArray->tracerArrayCount; i++) { \
tracerType prologueCallbackPtr; \
tracerType epilogue_callback_ptr; \
Expand Down Expand Up @@ -201,7 +201,7 @@ class APITracerCallbackDataImp {
currentTracerArray = \
(tracing_layer::tracer_array_t *) \
tracing_layer::pGlobalAPITracerContextImp->getActiveTracersList(); \
if (currentTracerArray) { \
if (currentTracerArray && currentTracerArray->tracerArrayCount > 0) { \
for (size_t i = 0; i < currentTracerArray->tracerArrayCount; i++){ \
tracerType prologueCallbackPtr; \
tracerType epilogue_callback_ptr; \
Expand Down Expand Up @@ -237,6 +237,15 @@ APITracerWrapperImp(TFunction_pointer zeApiPtr, TParams paramsStruct,
TRet ret {};
std::vector<APITracerCallbackStateImp<TTracer>> *callbacks_prologs =
&prologCallbacks;
std::vector<APITracerCallbackStateImp<TTracer>> *callbacksEpilogs =
&epilogCallbacks;
// Fast path: if no callbacks are registered, directly call the API
if (callbacks_prologs->empty() && callbacksEpilogs->empty()) {
ret = zeApiPtr(args...);
tracing_layer::tracingInProgress = 0;
tracing_layer::pGlobalAPITracerContextImp->releaseActivetracersList();
return ret;
}

std::vector<void *> ppTracerInstanceUserData;
ppTracerInstanceUserData.resize(callbacks_prologs->size());
Expand All @@ -248,8 +257,6 @@ APITracerWrapperImp(TFunction_pointer zeApiPtr, TParams paramsStruct,
&ppTracerInstanceUserData[i]);
}
ret = zeApiPtr(args...);
std::vector<APITracerCallbackStateImp<TTracer>> *callbacksEpilogs =
&epilogCallbacks;
for (size_t i = 0; i < callbacksEpilogs->size(); i++) {
if (callbacksEpilogs->at(i).current_api_callback != nullptr)
callbacksEpilogs->at(i).current_api_callback(
Expand Down
Loading