increase logger test coverage to 100% #1002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
100%
branch
2 times, most recently
from
8c122c6 to
eb2d104
Compare
ldorau
requested changes
Dec 18, 2024
| #ifndef UMF_VERSION | ||
| #define UMF_VERSION "test version" | ||
| #endif | ||
| // This trick to not work on windows |
test/utils/utils_log.cpp
Outdated
| EXPECT_EQ(fflush_count, expect_fflush_count); | ||
| } | ||
|
|
||
| // this test do not work on windows as we cannot mock abort on windows |
Contributor
|
@lplewa ping |
KFilipek
reviewed
Jan 17, 2025
| EXPECT_EQ(fflush_count, expect_fflush_count); | ||
| } | ||
|
|
||
| // this test doesn't work on windows as we cannot mock abort on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist