enable building examples on win static hwloc CI #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_enable_win_examples
branch
2 times, most recently
from
99bd17f to
37bffd9
Compare
bratpiorka
force-pushed
the
rrudnick_enable_win_examples
branch
from
7a5eb60 to
3d7f274
Compare
bratpiorka
force-pushed
the
rrudnick_enable_win_examples
branch
from
3d7f274 to
91f14d7
Compare
lukaszstolarczuk
approved these changes
Jan 2, 2025
PatKamin
approved these changes
Jan 2, 2025
lukaszstolarczuk
added a commit
to lukaszstolarczuk/unified-memory-framework
that referenced
this pull request
Jan 24, 2025
1. "enable building examples on win static hwloc CI" This reverts commit 58ba8e9. 2. "fix setting LIBHWLOC_LIBRARIES on Windows" This reverts commit 91f14d7. Ref. oneapi-src#1016
lukaszstolarczuk
added a commit
to lukaszstolarczuk/unified-memory-framework
that referenced
this pull request
Jan 24, 2025
1. "enable building examples on win static hwloc CI" This reverts commit 58ba8e9. 2. "fix setting LIBHWLOC_LIBRARIES on Windows" This reverts commit 91f14d7. Ref. oneapi-src#1016
bratpiorka
pushed a commit
to bratpiorka/unified-memory-framework
that referenced
this pull request
Jan 25, 2025
1. "enable building examples on win static hwloc CI" This reverts commit 58ba8e9. 2. "fix setting LIBHWLOC_LIBRARIES on Windows" This reverts commit 91f14d7. Ref. oneapi-src#1016
wlemkows
pushed a commit
to wlemkows/unified-memory-framework
that referenced
this pull request
Jan 29, 2025
1. "enable building examples on win static hwloc CI" This reverts commit 58ba8e9. 2. "fix setting LIBHWLOC_LIBRARIES on Windows" This reverts commit 91f14d7. Ref. oneapi-src#1016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Win builds with UMF_LINK_HWLOC_STATICALLY=ON the LIBHWLOC_LIBRARIES was not set while it is required to build examples
fixes https://github.com/oneapi-src/unified-memory-framework/actions/runs/12559062816/job/35014512726?pr=1016