Skip to content

Revert "Temporarily disable failing windows-2022 clang CI job" #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Revert "Temporarily disable failing windows-2022 clang CI job" #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b42b0c0
Fix building the coarse library on Windows
ldorau Feb 11, 2025
64ffe37
Revert "Temporarily disable failing windows-2022 clang CI job"
ldorau Feb 11, 2025
a2a9ba8
Use windows-2019 instead of windows-2022 in the Clang build
ldorau Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/reusable_basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,14 @@ jobs:
level_zero_provider: ['ON']
cuda_provider: ['ON']
include:
# temporarily disable failing CI job
#- os: 'windows-2022'
# build_type: Release
# compiler: {c: clang-cl, cxx: clang-cl}
# shared_library: 'ON'
# level_zero_provider: 'ON'
# cuda_provider: 'ON'
# toolset: "-T ClangCL"
- os: 'windows-2019'
# clang build fails on Windows 2022
build_type: Release
compiler: {c: clang-cl, cxx: clang-cl}
shared_library: 'ON'
level_zero_provider: 'ON'
cuda_provider: 'ON'
toolset: "-T ClangCL"
- os: 'windows-2022'
build_type: Release
compiler: {c: cl, cxx: cl}
Expand Down
4 changes: 2 additions & 2 deletions src/coarse/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Copyright (C) 2024 Intel Corporation
# Copyright (C) 2024-2025 Intel Corporation
# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

include(${UMF_CMAKE_SOURCE_DIR}/cmake/helpers.cmake)

set(COARSE_SOURCES coarse.c ../ravl/ravl.c)

if(UMF_BUILD_SHARED_LIBRARY)
if(UMF_BUILD_SHARED_LIBRARY AND (NOT WINDOWS))
set(COARSE_EXTRA_SRCS ${BA_SOURCES})
set(COARSE_EXTRA_LIBS $<BUILD_INTERFACE:umf_utils>)
endif()
Expand Down
Loading