Add CMake vars to dll's metadata #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
reviewed
Feb 14, 2025
bratpiorka
reviewed
Feb 14, 2025
lukaszstolarczuk
force-pushed
the
debug-win-ver
branch
from
e7f3f7e to
4f7d1f3
Compare
bratpiorka
previously approved these changes
Feb 14, 2025
PatKamin
reviewed
Feb 14, 2025
lukaszstolarczuk
force-pushed
the
debug-win-ver
branch
from
4f7d1f3 to
97e182d
Compare
Contributor
Author
|
neither custom field nor "Comments" were a good solution as were not displayed properly by default. I re-used "File description" - please let me know if this is an acceptable solution. |
bratpiorka
reviewed
Feb 18, 2025
Include more precise info on reading UMF vars and version; and add Windows part.
lukaszstolarczuk
force-pushed
the
debug-win-ver
branch
from
97e182d to
fb8838e
Compare
bratpiorka
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have "strings" on Linux, so add similar metadata to dll's rc files.
Describe it a little more in CONTRIBUTING.md