fix alloc / free aligned chunk address calc in disjoint pool #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
from
f0363f2 to
3b16dc3
Compare
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
from
3b16dc3 to
35ff0b4
Compare
lplewa
approved these changes
Feb 20, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
from
35ff0b4 to
c6954d4
Compare
kswiecicki
reviewed
Feb 20, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
2 times, most recently
from
9b5d2eb to
9b84da1
Compare
kswiecicki
approved these changes
Feb 20, 2025
KFilipek
requested changes
Feb 20, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
2 times, most recently
from
cf0936e to
6654dd1
Compare
KFilipek
approved these changes
Feb 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bratpiorka
force-pushed
the
rrudnick_fix_dp_asan
branch
from
6654dd1 to
efaf4ac
Compare
ldorau
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for calculating the chunk address in the Disjoint Pool when allocating memory with a specified alignment.
Note that in the current Disjoint Pool implementation, the origin of the slab isn't aligned,
so the chunks don't need to be aligned either (hence, I use the floor() function).
issues for TODOs:
param for disabling poisoning (for GPU provider): #1119
valgrind: #1120