Skip to content

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Feb 27, 2025

Description

Remove old SHM files /tmp/umf_file_provider_*
(at the beginning of the test)
left from the previous runs, because of crashes
of the ipc_file_prov test.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner February 27, 2025 07:01
@ldorau ldorau force-pushed the Remove_old_SHM_files_left_from_the_previous_runs_because_of_crashes branch from 88f8d28 to 0d637fc Compare February 27, 2025 08:42
@ldorau ldorau marked this pull request as draft February 27, 2025 09:19
@ldorau ldorau force-pushed the Remove_old_SHM_files_left_from_the_previous_runs_because_of_crashes branch from 0d637fc to 4af1446 Compare February 27, 2025 10:07
@ldorau ldorau force-pushed the Remove_old_SHM_files_left_from_the_previous_runs_because_of_crashes branch 2 times, most recently from 182ba44 to 49790a5 Compare March 17, 2025 10:29
Remove old SHM files /tmp/umf_file_provider_*
(at the beginning of the test)
left from the previous runs, because of crashes
of the ipc_file_prov test.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Remove_old_SHM_files_left_from_the_previous_runs_because_of_crashes branch from 49790a5 to ac6a2b2 Compare March 17, 2025 14:29
@ldorau
Copy link
Contributor Author

ldorau commented Mar 17, 2025

We cannot use tmpfile() nor mkstemp(), because those functions create and open a temporary file on their own, but we pass only a name of the file to the file provider and it opens this file on its own - we cannot force file memory provider to use only temporary files.

@ldorau ldorau marked this pull request as ready for review March 17, 2025 14:32
@ldorau ldorau requested review from bratpiorka and lplewa March 17, 2025 14:33
@lukaszstolarczuk
Copy link
Contributor

We cannot use tmpfile() nor mkstemp(), because those functions create and open a temporary file on their own, but we pass only a name of the file to the file provider and it opens this file on its own - we cannot force file memory provider to use only temporary files.

mktemp is would you're looking for, but the current solution is as good, I believe.
/tmp files are deleted on reboot... but we almost never do it 😉

@ldorau ldorau merged commit 3fc5fbc into oneapi-src:main Mar 17, 2025
85 checks passed
@ldorau ldorau deleted the Remove_old_SHM_files_left_from_the_previous_runs_because_of_crashes branch March 17, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants