Add annotations to umf_ba_alloc() and umf_ba_free()
#1145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dorau <[email protected]>
vinser52
reviewed
Feb 28, 2025
|
|
||
| utils_mutex_unlock(&pool->metadata.free_lock); | ||
|
|
||
| utils_annotate_acquire(chunk); |
Contributor
There was a problem hiding this comment.
@ldorau and I noticed similar code in tbb_malloc()/free() (however, in that case, the acquire/release is performed on the entire pool pointer, which could be invalid - ??). Generally, as I understand these calls, when an allocation is ready to be reused in another thread, all writes to it should be completed before returning it as a new allocation.
Contributor
There was a problem hiding this comment.
Isn't mutex above all ready introducing full memory barrier?
Contributor
Author
There was a problem hiding this comment.
Right, it will not be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add annotations to
umf_ba_alloc()andumf_ba_free().Checklist