-
Notifications
You must be signed in to change notification settings - Fork 42
Change umf_test-* tests' prefix to test_* #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change umf_test-* tests' prefix to test_* #1146
Conversation
71a24b2 to
510517e
Compare
510517e to
88d5156
Compare
|
If we are renaming test names, can we rename them in that way that we use only '-' or '_', not both. I find it really annoying when typing name of the test. |
According to GTest documentation each test should be named using camel-case - it should solve each problem. |
8548b6d to
625139c
Compare
4669655 to
2e7c6f4
Compare
2e7c6f4 to
51ba72a
Compare
|
So with this change we would have Other, non-blocking, comment - the naming convention of umf tests is just for easy grepping of tests binaries as they are not installed with umf. As they are not-installed-binaries I would prefer a more convenient naming of tests like |
|
I vote for combining both - Patryk's and Lukasz's proposals: |
51ba72a to
9d797c5
Compare
9d797c5 to
cb94612
Compare
Description
Checklist