Install debug libraries on Windows #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Mar 25, 2025
PatKamin
force-pushed
the
debug-dll
branch
3 times, most recently
from
0c4b350 to
ad081ef
Compare
bratpiorka
reviewed
Mar 26, 2025
bratpiorka
reviewed
Mar 26, 2025
PatKamin
force-pushed
the
debug-dll
branch
9 times, most recently
from
24d186d to
c4fc00a
Compare
bratpiorka
reviewed
Mar 31, 2025
| # users can link against it in debug builds. | ||
| set(CMAKE_DEBUG_POSTFIX d) | ||
|
|
||
| add_custom_target( |
Contributor
There was a problem hiding this comment.
could you also add comment here?
bratpiorka
approved these changes
Mar 31, 2025
KFilipek
reviewed
Mar 31, 2025
when UMF_USE_DEBUG_POSTFIX CMake option is set.
KFilipek
approved these changes
Mar 31, 2025
kbenzie
reviewed
Apr 2, 2025
Comment on lines
+443
to
+449
| add_custom_command( | ||
| TARGET umfd | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_BINARY_DIR}/bin/Debug/umfd.dll | ||
| ${CMAKE_BINARY_DIR}/bin/Release/umfd.dll | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_BINARY_DIR}/lib/Debug/umfd.lib | ||
| ${CMAKE_BINARY_DIR}/lib/Release/umfd.lib | ||
| COMMENT "Copying debug libraries to the Release build directory") |
Contributor
There was a problem hiding this comment.
This breaks when using Ninja generator (I assume also Unix Makefiles which is what internal builds use).
kbenzie
reviewed
Apr 2, 2025
Comment on lines
+846
to
+849
| install(FILES ${CMAKE_BINARY_DIR}/bin/Debug/umfd.dll | ||
| DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
| install(FILES ${CMAKE_BINARY_DIR}/lib/Debug/umfd.lib | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}) |
Contributor
There was a problem hiding this comment.
And so do these. Also unable to install only these because there's no COMPONENT to name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always install debug libraries on Windows. Introduce new CMake option
UMF_USE_DEBUG_POSTFIXfor adding a "d" postfix to debug libraries names.These changes are required for intel/llvm#17512.
Checklist