Skip to content

Check for autoreconf prerequisite in case hwloc is fetched from sources #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Check for autoreconf prerequisite in case hwloc is fetched from sources #1229

merged 1 commit into from
Apr 3, 2025

Conversation

@PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Mar 31, 2025 •
edited
Loading

Description

Check for autoreconf prerequisite in case hwloc is fetched from sources.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

@PatKamin PatKamin force-pushed the autoreconf-check branch 2 times, most recently from 8a6c0cf to 41a048f Compare April 1, 2025 03:54
@PatKamin PatKamin marked this pull request as ready for review April 1, 2025 03:57
@PatKamin PatKamin requested a review from a team as a code owner April 1, 2025 03:57
@PatKamin PatKamin requested a review from bratpiorka April 1, 2025 03:57
@PatKamin PatKamin changed the title Add warning for missing autoreconf in hwloc fetch Check for autoreconf prerequisite in case hwloc is fetched from sources Apr 1, 2025
@PatKamin PatKamin force-pushed the autoreconf-check branch 2 times, most recently from 0169b35 to 9c8b6b9 Compare April 1, 2025 11:49
@PatKamin
Disable hwloc in case of missing autoreconf
f4358ea 
Search for autoreconf package in the Linux system before trying to fetch
and build the hwloc library.
@PatKamin
Copy link
Contributor Author

PatKamin commented Apr 3, 2025

Internal tests and Nightly passed: https://github.com/PatKamin/unified-memory-framework/actions/runs/14218220477

@bratpiorka bratpiorka requested a review from KFilipek April 3, 2025 11:52
@KFilipek KFilipek merged commit 18fb231 into oneapi-src:main Apr 3, 2025
254 of 257 checks passed
@PatKamin PatKamin deleted the autoreconf-check branch June 27, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KFilipek KFilipek KFilipek approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatKamin @KFilipek @bratpiorka