Skip to content

update compat wflow tag and remove filters #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

update compat wflow tag and remove filters #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f89a467
update compat workflow tags to v0.11.0-rc1
bratpiorka Apr 3, 2025
90bee84
enable filtered tests in compat wflow
bratpiorka Apr 3, 2025
6586a94
remove umfMemoryTrackerGetAllocInfo from def/map files
bratpiorka Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,6 @@ jobs:
uses: ./.github/workflows/reusable_compatibility.yml
strategy:
matrix:
tag: ["v0.11.0-dev1"]
tag: ["v0.11.0-rc1"]
with:
tag: ${{matrix.tag}}
24 changes: 5 additions & 19 deletions .github/workflows/reusable_compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
tag:
description: Check backward compatibility with this tag
type: string
default: "v0.11.0-dev1"
default: "v0.11.0-rc1"

permissions:
contents: read
Expand Down Expand Up @@ -99,14 +99,10 @@ jobs:

- name: Run "tag" UMF tests with latest UMF libs (warnings enabled)
working-directory: ${{github.workspace}}/tag_version/build
# Disable incompatible tests:
# - GTEST_FILTER used to skip only single test cases
# - ctest's exclude - disable test binary that rely on internal structures
run: >
UMF_LOG="level:warning;flush:debug;output:stderr;pid:no"
LD_LIBRARY_PATH=${{github.workspace}}/latest_version/build/lib/
GTEST_FILTER="-*umfIpcTest.GetPoolByOpenedHandle*"
ctest --verbose -E "umf-mempolicy"
ctest --verbose

# Browse all folders in the examples directory, build them using the
# latest UMF version, and run them, excluding those in the exclude list.
Expand Down Expand Up @@ -215,11 +211,8 @@ jobs:

- name: Run "tag" UMF tests with latest UMF libs (warnings enabled)
working-directory: ${{github.workspace}}/tag_version/build
# Disable incompatible tests:
# - GTEST_FILTER used to skip only single test cases
run: |
$env:UMF_LOG="level:warning;flush:debug;output:stderr;pid:no"
$env:GTEST_FILTER="-*umfIpcTest.GetPoolByOpenedHandle*"
cp ${{github.workspace}}/latest_version/build/bin/Debug/umf.dll ${{github.workspace}}/tag_version/build/bin/Debug/umf.dll
ctest -C Debug --verbose

Expand Down Expand Up @@ -345,29 +338,22 @@ jobs:
working-directory: ${{github.workspace}}/tag_version/build
run: >
LD_LIBRARY_PATH=${{github.workspace}}/tag_version/build/lib/
GTEST_FILTER="-*umfIpcTest.GetPoolByOpenedHandle*"
ctest --output-on-failure

- name: Run "tag" UMF tests with latest UMF libs (warnings enabled)
working-directory: ${{github.workspace}}/tag_version/build
# Disable incompatible tests:
# - GTEST_FILTER used to skip only single test cases
# - ctest's exclude - disable test binary that rely on internal structures
# and once not implemented features may now be implemented.
run: >
UMF_LOG="level:warning;flush:debug;output:stderr;pid:no"
LD_LIBRARY_PATH=${{github.workspace}}/latest_version/build/lib/
GTEST_FILTER="-*umfIpcTest.GetPoolByOpenedHandle*"
ctest --verbose -E "not_impl|umf-mempolicy"
ctest --verbose

# Browse all folders in the examples directory, build them using the
# latest UMF version, and run them, excluding those in the exclude list.
# NOTE: exclude cuda examples as they require linking with static disjoint
# pool library
# NOTE: exclude either CUDA or Level Zero examples depending on the GPU
- name: Build and run "tag" examples using the latest UMF libraries
working-directory: ${{github.workspace}}/tag_version
run: |
EXAMPLES_EXCLUDE_LIST="cmake|common|hmat|cuda${{matrix.provider == 'LEVEL_ZERO' && '' || '|level_zero' }}"
EXAMPLES_EXCLUDE_LIST="cmake|common|hmat|${{matrix.provider == 'LEVEL_ZERO' && 'cuda' || 'level_zero' }}"
rm -rf build
rm -rf include
mkdir _examples
Expand Down
1 change: 0 additions & 1 deletion src/libumf.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ EXPORTS
umfMemoryProviderPurgeForce
umfMemoryProviderPurgeLazy
umfMemoryProviderPutIPCHandle
umfMemoryTrackerGetAllocInfo
umfMempolicyCreate
umfMempolicyDestroy
umfMempolicySetCustomSplitPartitions
Expand Down
1 change: 0 additions & 1 deletion src/libumf.map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ UMF_0.10 {
umfMemoryProviderPurgeForce;
umfMemoryProviderPurgeLazy;
umfMemoryProviderPutIPCHandle;
umfMemoryTrackerGetAllocInfo;
umfMempolicyCreate;
umfMempolicyDestroy;
umfMempolicySetCustomSplitPartitions;
Expand Down