Skip to content

[0.11.x] Disable hwloc in case of missing autoreconf #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

[0.11.x] Disable hwloc in case of missing autoreconf #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,37 +243,45 @@ else()
)
endif()

if(UMF_DISABLE_HWLOC)
message(STATUS "hwloc is disabled, hence OS provider, memtargets, "
"topology discovery, examples won't be available!")
else()
if(NOT DEFINED UMF_HWLOC_REPO)
set(UMF_HWLOC_REPO "https://github.com/open-mpi/hwloc.git")
if(NOT UMF_DISABLE_HWLOC AND (NOT UMF_LINK_HWLOC_STATICALLY))
pkg_check_modules(LIBHWLOC hwloc>=2.3.0)
if(NOT LIBHWLOC_FOUND)
find_package(LIBHWLOC 2.3.0 COMPONENTS hwloc)
if(LIBHWLOC_LIBRARIES)
set(LIBHWLOC_AVAILABLE TRUE)
endif()
endif()

if(NOT DEFINED UMF_HWLOC_TAG)
set(UMF_HWLOC_TAG hwloc-2.10.0)
if(LIBHWLOC_AVAILABLE OR LIBHWLOC_FOUND)
# add PATH to DLL on Windows
set(DLL_PATH_LIST
"${DLL_PATH_LIST};PATH=path_list_append:${LIBHWLOC_DLL_DIRS}")
else()
set(UMF_LINK_HWLOC_STATICALLY ON)
endif()
endif()

if(NOT UMF_LINK_HWLOC_STATICALLY)
pkg_check_modules(LIBHWLOC hwloc>=2.3.0)
if(NOT LIBHWLOC_FOUND)
find_package(LIBHWLOC 2.3.0 COMPONENTS hwloc)
if(LIBHWLOC_LIBRARIES)
set(LIBHWLOC_AVAILABLE TRUE)
endif()
endif()

if(LIBHWLOC_AVAILABLE OR LIBHWLOC_FOUND)
# add PATH to DLL on Windows
set(DLL_PATH_LIST
"${DLL_PATH_LIST};PATH=path_list_append:${LIBHWLOC_DLL_DIRS}")
else()
set(UMF_LINK_HWLOC_STATICALLY ON)
endif()
if(UMF_LINK_HWLOC_STATICALLY AND LINUX)
find_program(AUTORECONF_EXECUTABLE autoreconf)
if(NOT AUTORECONF_EXECUTABLE)
message(WARNING "autoreconf is not installed. Disabling hwloc.")
set(UMF_DISABLE_HWLOC ON)
set(UMF_LINK_HWLOC_STATICALLY OFF)
endif()
endif()

if(UMF_DISABLE_HWLOC)
message(STATUS "hwloc is disabled, hence OS provider, memtargets, "
"topology discovery, examples won't be available!")
else()
if(UMF_LINK_HWLOC_STATICALLY)
if(NOT DEFINED UMF_HWLOC_REPO)
set(UMF_HWLOC_REPO "https://github.com/open-mpi/hwloc.git")
endif()

if(NOT DEFINED UMF_HWLOC_TAG)
set(UMF_HWLOC_TAG hwloc-2.10.0)
endif()
message(
STATUS
"Will fetch hwloc from ${UMF_HWLOC_REPO} (tag: ${UMF_HWLOC_TAG})"
Expand Down