Skip to content

disable fragmentation output for peak benchmark #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

disable fragmentation output for peak benchmark #1261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion benchmark/benchmark.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ class multiple_malloc_free_benchmark : public benchmark_interface<Size, Alloc> {
typename std::vector<next_alloc_data>::const_iterator;
std::vector<std::unique_ptr<next_alloc_data_iterator>> next_iter;
int64_t iterations;
bool log_fragmentation;
multiple_malloc_free_benchmark(bool log_fragmentation = true)
: log_fragmentation(log_fragmentation) {}

public:
void SetUp(::benchmark::State &state) override {
Expand Down Expand Up @@ -350,7 +353,7 @@ class multiple_malloc_free_benchmark : public benchmark_interface<Size, Alloc> {
void TearDown(::benchmark::State &state) override {
base::allocator.postBench(state);
auto tid = state.thread_index();
if (tid == 0) {
if (tid == 0 && log_fragmentation) {
size_t current_memory_allocated = 0;
for (const auto &allocationsPerThread : allocations) {
for (const auto &allocation : allocationsPerThread) {
Expand Down Expand Up @@ -517,7 +520,12 @@ template <
std::enable_if_t<std::is_base_of<allocator_interface, Alloc>::value>>
class peak_alloc_benchmark
: public multiple_malloc_free_benchmark<Size, Alloc> {

using base = multiple_malloc_free_benchmark<Size, Alloc>;

public:
peak_alloc_benchmark() : base(false) {}

virtual void prepareWorkload(benchmark::State &state) override {
// Retrieve the thread index and corresponding operation buffer.
auto tid = state.thread_index();
Expand Down