Skip to content

Downgrade error logs to debug in memspaces and memtargets #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Downgrade error logs to debug in memspaces and memtargets #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/memspaces/memspace_highest_bandwidth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
*
* Copyright (C) 2024 Intel Corporation
* Copyright (C) 2024-2025 Intel Corporation
*
* Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Expand Down Expand Up @@ -102,7 +102,7 @@ static void umfMemspaceHighestBandwidthInit(void) {
umf_result_t ret =
umfMemspaceHighestBandwidthCreate(&UMF_MEMSPACE_HIGHEST_BANDWIDTH);
if (ret != UMF_RESULT_SUCCESS) {
LOG_ERR(
LOG_DEBUG(
"Creating the highest bandwidth memspace failed with the error: %u",
ret);
assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED);
Expand Down
4 changes: 2 additions & 2 deletions src/memspaces/memspace_lowest_latency.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
*
* Copyright (C) 2024 Intel Corporation
* Copyright (C) 2024-2025 Intel Corporation
*
* Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Expand Down Expand Up @@ -98,7 +98,7 @@ static void umfMemspaceLowestLatencyInit(void) {
umf_result_t ret =
umfMemspaceLowestLatencyCreate(&UMF_MEMSPACE_LOWEST_LATENCY);
if (ret != UMF_RESULT_SUCCESS) {
LOG_ERR(
LOG_DEBUG(
"Creating the lowest latency memspace failed with the error: %u",
ret);
assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED);
Expand Down
17 changes: 9 additions & 8 deletions src/memtargets/memtarget_numa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ static umf_result_t query_attribute_value(void *srcMemoryTarget,
int ret = hwloc_memattr_get_value(topology, hwlocMemAttrType, dstNumaNode,
&initiator, 0, &memAttrValue);
if (ret) {
LOG_PERR("Getting an attribute value for a specific target NUMA node "
"failed");
LOG_PDEBUG("Getting an attribute value for a specific target NUMA node "
"failed");
return (errno == EINVAL) ? UMF_RESULT_ERROR_NOT_SUPPORTED
: UMF_RESULT_ERROR_UNKNOWN;
}
Expand All @@ -330,9 +330,10 @@ static umf_result_t numa_get_bandwidth(void *srcMemoryTarget,
umf_result_t ret = query_attribute_value(srcMemoryTarget, dstMemoryTarget,
bandwidth, MEMATTR_TYPE_BANDWIDTH);
if (ret) {
LOG_ERR("Retrieving bandwidth for initiator node %u to node %u failed.",
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
LOG_DEBUG(
"Retrieving bandwidth for initiator node %u to node %u failed.",
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
return ret;
}

Expand All @@ -348,9 +349,9 @@ static umf_result_t numa_get_latency(void *srcMemoryTarget,
umf_result_t ret = query_attribute_value(srcMemoryTarget, dstMemoryTarget,
latency, MEMATTR_TYPE_LATENCY);
if (ret) {
LOG_ERR("Retrieving latency for initiator node %u to node %u failed.",
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
LOG_DEBUG("Retrieving latency for initiator node %u to node %u failed.",
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
return ret;
}

Expand Down
Loading